GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — enum: remove unused function by methane · Pull Request #132044 · python/cpython

Conversation

@methane

@methane methane commented Apr 3, 2025

Copy link
Copy Markdown
Member

_dedent in enum was added in this PR.

https://github.com/python/cpython/pull/30582/files#diff-e5dd6e444e4e6c2cdeb8edf271d057f9da52f7b406dcd8b655dc396fb013bd03

But it is not used now.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@methane
enum: remove unused function
de9d7aa
@methane methane added skip issue skip news labels Apr 3, 2025
@python-cla-bot

python-cla-bot Bot commented Apr 6, 2025

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

CLA signed
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@methane
methane marked this pull request as ready for review April 6, 2025 23:45
@methane
methane requested a review from ethanfurman as a code owner April 6, 2025 23:45
@bedevere-app bedevere-app Bot added the awaiting core review label Apr 6, 2025
@methane
methane requested a review from Copilot April 6, 2025 23:45

This comment was marked as off-topic.

Sign in to view

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
hugovk
hugovk approved these changes Apr 7, 2025
View reviewed changes

@hugovk hugovk left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

History: _dedent was added in #30582 (then briefly reverted in #30632 and re-added in #30637) in v3.11.0a5.

Then its use was removed in #94188 in v3.12.0a1 but the function not removed.

I think it's safe to remove the function: it wasn't documented, was underscore prefixed, is very similar to textwrap.dedent() which should be the first choice, and I don't find any use of _dedent on GitHub code search.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
zware reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Apr 7, 2025
AA-Turner
AA-Turner approved these changes Apr 7, 2025
View reviewed changes
@methane
methane merged commit e2b35ee into python:main Apr 8, 2025
@methane
methane deleted the enum_remove_unused branch April 8, 2025 00:23
@bedevere-app bedevere-app Bot removed the awaiting merge label Apr 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@hugovk hugovk hugovk approved these changes
@AA-Turner AA-Turner AA-Turner approved these changes
@ethanfurman ethanfurman Awaiting requested review from ethanfurman ethanfurman is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@methane @hugovk @AA-Turner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.