GeezerVison

It might be worth adding a _pytypes module to hold the pure-Python fallbacks.

As in the following?

try:
    from _types import *
except ImportError:
    from _pytypes import *

Could you elaborate on the benefits?

Could you elaborate on the benefits?

One benefit is that it reduces by one the indentation level and it's easier to read/modify I think. Also, we do it for _pydecimal so why not doing it for _pytypes?

Could you elaborate on the benefits?

Yeah, what Bénédikt said. It seems cleaner to encapsulate each implementation.

Also, we do it for _pydecimal so why not doing it for _pytypes?

_pydecimal, _pyio, etc are Python implementations of the C accelarator modules (see PEP-0399), whereas types still contains quite a lot only implemented in Python. See e.g. collections and functools which use extension modules, but don't have a _py<mod> helper module.

A

I don't have much of a preference, it's just prettier. Are we planning to implement the other functions in C?

Are we planning to implement the other functions in C?

I'm not personally, though Yury left a TODO comment by _GeneratorWrapper about implementing it in C. I'd probably prefer to keep the simpler functions in Python, but there might be benefits I haven't considered to converting to C.

A