GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-131798: Allow the JIT to remove an extra _TO_BOOL_BOOL for _CONTAINS_OP_DICT by Zheaoli · Pull Request #132269 · python/cpython

Conversation

@Zheaoli

@Zheaoli Zheaoli commented Apr 8, 2025 •
edited by Fidget-Spinner
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: Better uop coverage in the JIT optimizer #131798

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Zheaoli
Zheaoli requested a review from Fidget-Spinner as a code owner April 8, 2025 13:22
@bedevere-app bedevere-app Bot added the awaiting review label Apr 8, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Apr 8, 2025
Better uop coverage in the JIT optimizer #131798
Open
@Zheaoli
Zheaoli marked this pull request as draft April 8, 2025 13:22
@bedevere-app bedevere-app Bot removed the awaiting review label Apr 8, 2025
@Fidget-Spinner

Fidget-Spinner commented Apr 8, 2025

Copy link
Copy Markdown
Member

Will review this soon! I removed the "fix X" in the PR description because that issue still has a lot left to be done.
Zheaoli reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
tomasr8
tomasr8 reviewed Apr 8, 2025
View reviewed changes
Comment thread Lib/test/test_capi/test_opt.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Fidget-Spinner
Fidget-Spinner approved these changes Apr 8, 2025
View reviewed changes
@bedevere-app bedevere-app Bot added the awaiting merge label Apr 8, 2025
@Zheaoli
Zheaoli marked this pull request as ready for review April 8, 2025 14:23
@bedevere-app bedevere-app Bot added awaiting review and removed awaiting merge labels Apr 8, 2025
Zheaoli and others added 3 commits April 8, 2025 22:25
@Zheaoli
pythongh-131798: Allow the JIT to remove an extra _TO_BOOL_BOOL for _…
adf36c3 
…CONTAINS_OP_DICT

Signed-off-by: Manjusaka <[email protected]>
@Zheaoli @tomasr8
Update Lib/test/test_capi/test_opt.py
2666455 
Co-authored-by: Tomas R. <[email protected]>
@Zheaoli
fix review idea
82121ee 
Signed-off-by: Manjusaka <[email protected]>
@Zheaoli
Zheaoli force-pushed the manjusaka/gh-130415 branch from 3558eb7 to 82121ee Compare April 8, 2025 14:25
brandtbucher
brandtbucher approved these changes Apr 8, 2025
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Apr 8, 2025
@brandtbucher
brandtbucher merged commit d753d8a into python:main Apr 8, 2025
@bedevere-app bedevere-app Bot removed the awaiting merge label Apr 8, 2025
@Zheaoli
Zheaoli deleted the manjusaka/gh-130415 branch April 8, 2025 17:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tomasr8 tomasr8 tomasr8 left review comments
@Fidget-Spinner Fidget-Spinner Fidget-Spinner approved these changes
@brandtbucher brandtbucher brandtbucher approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@Zheaoli @Fidget-Spinner @tomasr8 @brandtbucher
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.