GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-132426: `get_annotate_function` vs. mapping namespaces by eliegoudout · Pull Request #132427 · python/cpython

Conversation

@eliegoudout

@eliegoudout eliegoudout commented Apr 12, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

Closes #132426

  • Issue: annotationlib: namespace can be non-dict #132426

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@eliegoudout
fix: ns can be mapping (closes python#132426)
93afac8 
Signed-off-by: Élie Goudout <[email protected]>
@eliegoudout
eliegoudout requested a review from JelleZijlstra as a code owner April 12, 2025 08:40
@python-cla-bot

python-cla-bot Bot commented Apr 12, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown

All commit authors signed the Contributor License Agreement.

CLA signed
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot added the awaiting review label Apr 12, 2025
@bedevere-app

bedevere-app Bot commented Apr 12, 2025

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@picnixz picnixz changed the title fix annotationlib: namespace can be mapping (closes #132426) gh-132426: get_annotate_function should allow mapping-like objects Apr 12, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Apr 12, 2025
annotationlib: namespace can be non-dict #132426
Closed
@eliegoudout

eliegoudout commented Apr 12, 2025

Copy link
Copy Markdown
Author

I convert back to draft because of this.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@eliegoudout
eliegoudout marked this pull request as draft April 12, 2025 08:58
@bedevere-app bedevere-app Bot removed the awaiting review label Apr 12, 2025
@eliegoudout eliegoudout changed the title gh-132426: get_annotate_function should allow mapping-like objects gh-132426: get_annotate_function vs. mapping namespaces Apr 12, 2025
picnixz
picnixz reviewed Apr 12, 2025
View reviewed changes
Comment thread Lib/annotationlib.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@eliegoudout
Mapping from collections.abc, local
a4ad2c6 
Signed-off-by: Élie Goudout <[email protected]>
@bedevere-app

bedevere-app Bot commented Apr 12, 2025

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@JelleZijlstra

JelleZijlstra commented May 4, 2025

Copy link
Copy Markdown
Member

Closing in favor of #132490
eliegoudout reacted with hooray emoji
All reactions
  • 🎉 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@JelleZijlstra JelleZijlstra closed this May 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@picnixz picnixz picnixz left review comments
@JelleZijlstra JelleZijlstra Awaiting requested review from JelleZijlstra JelleZijlstra is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

annotationlib: namespace can be non-dict

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@eliegoudout @JelleZijlstra @picnixz
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.