GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||||||||||||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||||||||||||||
GeezerVison is showing github.com — gh-131798: Use `sym_new_type` instead of `sym_new_not_null` for `_BUILD_LIST`, `_BUILD_SLICE`, and `_BUILD_MAP` by Zheaoli · Pull Request #132434 · python/cpython Conversation
|
|
|
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
@Fidget-Spinner I think I still have some work for this PR A few days ago, In #132289, @brandtbucher setup optimization path for I'm not sure this is what we want to get(I guess it's, so maybe we just need to patch the test?) |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
sym_new_type instead of sym_new_not_null for _BUILD_LIST, _BUILD_SET, _BUILD_MAPsym_new_type instead of sym_new_not_null for _BUILD_LIST, _BUILD_SLICE, _BUILD_MAP
sym_new_type instead of sym_new_not_null for _BUILD_LIST, _BUILD_SLICE, _BUILD_MAPsym_new_type instead of sym_new_not_null for _BUILD_LIST, _BUILD_SLICE, and _BUILD_MAP
There was an error while loading. Please reload this page.
|
@Zheaoli, that's actually a good thing! The additional information that you've added to the optimizer for (I don't think writing a test for the |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Yes, I guess the |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
5101fc8 to
1e69348
Compare
| self.assertIsNotNone(ex) | ||
| uops = get_opnames(ex) | ||
| self.assertEqual(uops.count("_GUARD_NOS_LIST"), 1) | ||
| self.assertEqual(uops.count("_GUARD_NOS_LIST"), 0) |
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Can you please update the comment above and change Guarded to Unguarded. The guard has now been removed.
Same for test_remove_guard_for_known_type_dict
Sorry, something went wrong.
There was an error while loading. Please reload this page.
… _BUILD_LIST, _BUILD_SET, _BUILD_MAP Signed-off-by: Manjusaka <[email protected]>
Signed-off-by: Manjusaka <[email protected]>
Signed-off-by: Manjusaka <[email protected]>
Signed-off-by: Manjusaka <[email protected]>
Signed-off-by: Manjusaka <[email protected]>
8d55bc4 to
839a749
Compare
|
@Zheaoli please don't force push, just normal push so we can see the commit diff. We will squash and merge at the end as one commit. Thanks! |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
The reason will be displayed to describe this comment to others. Learn more.
Thanks again! Great job.
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.