GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-131798: Use `sym_new_type` instead of `sym_new_not_null` for _BUILD_STRING, _BUILD_SET by Zheaoli · Pull Request #132564 · python/cpython

Conversation

@Zheaoli

@Zheaoli Zheaoli commented Apr 15, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

This PR is under developing, not ready for review

  • Issue: Better uop coverage in the JIT optimizer #131798

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@Zheaoli
pythongh-131798: Add JIT path for _BUILD_STRING
6dc906f 
Signed-off-by: Manjusaka <[email protected]>
@bedevere-app bedevere-app Bot mentioned this pull request Apr 15, 2025
Better uop coverage in the JIT optimizer #131798
Open
Zheaoli added 3 commits April 16, 2025 03:07
@Zheaoli
pythongh-131798: Add JIT path for _BUILD_STRING
11ea46e 
Signed-off-by: Manjusaka <[email protected]>
@Zheaoli
pythongh-131798: Add JIT path for _BUILD_STRING
ab00ff4 
Signed-off-by: Manjusaka <[email protected]>
@Zheaoli
pythongh-131798: Add JIT path for _BUILD_STRING
445ec7d 
Signed-off-by: Manjusaka <[email protected]>
@Zheaoli

Zheaoli commented Apr 16, 2025

Copy link
Copy Markdown
Contributor Author

@brandtbucher Hi Brandt, I might need some help here.

I have already optimization path for _BUILD_STRING(I think we just need setup the const after we check all the opargs string on stack.

But I got a little bit confused for _BUILD_STRING. If I'm correct, _BUILD_SLICE is equal with BUILD_SLISE, I'm not sure it's necessary add an optimization path for _BUILD_SLICE. The result is const or not is not related with the argument?(not sure about this)
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@brandtbucher

brandtbucher commented Apr 24, 2025

Copy link
Copy Markdown
Member

Hi @Zheaoli! Let's start by just setting the output types for these. I think maybe the constant output stuff may not be needed after all, due to GH-132733.
Zheaoli reacted with thumbs up emoji Zheaoli reacted with heart emoji
All reactions
  • 👍 1 reaction
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Zheaoli added 2 commits April 26, 2025 18:42
@Zheaoli
Set type for string and slice
720915d 
Signed-off-by: Manjusaka <[email protected]>
@Zheaoli
Update news
c6599c2 
Signed-off-by: Manjusaka <[email protected]>
@Zheaoli Zheaoli changed the title gh-131798: Add JIT path for _BUILD_STRING gh-131798: Use sym_new_type instead of sym_new_not_null for _BUILD_STRING, _BUILD_SLICE Apr 26, 2025
Zheaoli added 2 commits April 26, 2025 19:49
@Zheaoli
Merge branch 'main' into manjusaka/build-string
336e6e4
@Zheaoli
Update code
52a4d34 
Signed-off-by: Manjusaka <[email protected]>
@Zheaoli Zheaoli changed the title gh-131798: Use sym_new_type instead of sym_new_not_null for _BUILD_STRING, _BUILD_SLICE gh-131798: Use sym_new_type instead of sym_new_not_null for _BUILD_STRING, _BUILD_SET Apr 26, 2025
Zheaoli added 3 commits April 26, 2025 19:51
@Zheaoli
Update code
bdba96c 
Signed-off-by: Manjusaka <[email protected]>
@Zheaoli
Update code
14b575f 
Signed-off-by: Manjusaka <[email protected]>
@Zheaoli
Update code
9e74374 
Signed-off-by: Manjusaka <[email protected]>
@Zheaoli
Zheaoli marked this pull request as ready for review April 26, 2025 12:10
@Zheaoli
Zheaoli requested a review from Fidget-Spinner as a code owner April 26, 2025 12:10
@bedevere-app bedevere-app Bot added the awaiting review label Apr 26, 2025
Fidget-Spinner
Fidget-Spinner reviewed Apr 26, 2025
View reviewed changes
Comment thread Python/optimizer_bytecodes.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Fidget-Spinner
Fidget-Spinner approved these changes Apr 26, 2025
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Apr 26, 2025
Zheaoli and others added 2 commits April 27, 2025 12:08
@Zheaoli
Update code
0857852 
Signed-off-by: Manjusaka <[email protected]>
@Fidget-Spinner
Merge branch 'main' into manjusaka/build-string
43565a4
@Fidget-Spinner
Fidget-Spinner merged commit 614d792 into python:main Apr 27, 2025
@bedevere-app bedevere-app Bot removed the awaiting merge label Apr 27, 2025
@Zheaoli
Zheaoli deleted the manjusaka/build-string branch April 27, 2025 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Fidget-Spinner Fidget-Spinner Fidget-Spinner approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@Zheaoli @brandtbucher @Fidget-Spinner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.