GeezerVison is showing github.com — GH-132554: Add stats for GET_ITER by markshannon · Pull Request #132592 · python/cpython
Conversation
markshannon
commented
Apr 16, 2025
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
Before we can specialize GET_ITER, or even decide if it is worth specializing GET_ITER, we need stats.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
I bet a lot of the "other" will already be iterators. It may be worth adding a stat at the end, before "other", for types where tp->tp_iter == PyObject_SelfIter. At least for that case we can specialize it and do nothing.
(I wish we could also "unwrap" list, tuple, and range iterators, similar in spirit to our method call optimization. Basically, if GET_ITER encounters a list_iterator, range_iterator, or tuple_iterator we just put the container itself and the current index on the stack. But that's not safe to do if its refcount is greater than one, unfortunately.)
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.