GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-132657: Avoid locking in frozenset.__contains__ by eendebakpt · Pull Request #132659 · python/cpython

Conversation

@eendebakpt

@eendebakpt eendebakpt commented Apr 17, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor
  • Issue: copy.copy and copy.deepcopy scale poorly with free-threading #132657

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@eendebakpt
Avoid locking in frozenset.__contains__
e317c72
@eendebakpt
eendebakpt requested a review from rhettinger as a code owner April 17, 2025 19:36
@bedevere-app bedevere-app Bot added the awaiting review label Apr 17, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Apr 17, 2025
copy.copy and copy.deepcopy scale poorly with free-threading #132657
Closed
@eendebakpt
fix build
6903e01
@rhettinger

rhettinger commented Apr 17, 2025

Copy link
Copy Markdown
Contributor

To my eyes, the new code looks identical to the existing set___contains___impl.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@eendebakpt

eendebakpt commented Apr 17, 2025

Copy link
Copy Markdown
Contributor Author

Almost identical, except that the set___contains___impl has an extra line @critical_section. This results in a Py_BEGIN_CRITICAL_SECTION in the clinic generated code.
rhettinger reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
rhettinger
rhettinger approved these changes Apr 18, 2025
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Apr 18, 2025
colesbury
colesbury approved these changes Apr 18, 2025
View reviewed changes
@kumaraditya303 kumaraditya303 added the skip news label Apr 18, 2025
kumaraditya303
kumaraditya303 approved these changes Apr 18, 2025
View reviewed changes
@kumaraditya303
kumaraditya303 merged commit e77d678 into python:main Apr 18, 2025
@bedevere-app bedevere-app Bot removed the awaiting merge label Apr 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@colesbury colesbury colesbury approved these changes
@rhettinger rhettinger rhettinger approved these changes
@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@eendebakpt @rhettinger @colesbury @kumaraditya303
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.