GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-130167: Improve the error case for ``textwrap.dedent`` by AA-Turner · Pull Request #132666 · python/cpython

Conversation

@AA-Turner

@AA-Turner AA-Turner commented Apr 18, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

cc @hroncok @picnixz

  • Issue: Improve speed of stdlib functions by replacing re uses #130167

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@AA-Turner
Improve the error case for textwrap.dedent
4c820cd
@AA-Turner AA-Turner added the skip news label Apr 18, 2025
@bedevere-app bedevere-app Bot added the awaiting core review label Apr 18, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Apr 18, 2025
Improve speed of stdlib functions by replacing re uses #130167
Open
@hroncok

hroncok commented Apr 18, 2025

Copy link
Copy Markdown
Contributor

Would it be possible to add a test for this?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
picnixz
picnixz reviewed Apr 18, 2025
View reviewed changes
Comment thread Lib/textwrap.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@AA-Turner
Add a test
d236d0c
@hroncok

hroncok commented Apr 18, 2025

Copy link
Copy Markdown
Contributor

Thanks. I suppose bytes would still TypeError implicitly, right?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AA-Turner
Improve the error message for bytes
ec839ff
@AA-Turner

AA-Turner commented Apr 18, 2025

Copy link
Copy Markdown
Member Author

Yes, but with an error message from bytes.split. I've pushed an improvement.
hroncok reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
AA-Turner added 2 commits April 18, 2025 18:24
@AA-Turner
Suppress BytesWarning
1902d1c
@AA-Turner
Remove fast path
a996f00
picnixz
picnixz approved these changes Apr 19, 2025
View reviewed changes

@picnixz picnixz left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Out of curiosity, can we have the benchmarks for this change on empty strings? I don't think we lose much but I'm just curious.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Apr 19, 2025
@AA-Turner

AA-Turner commented Apr 19, 2025

Copy link
Copy Markdown
Member Author

I won't have time in the near future to run benchmarks.

A
picnixz reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AA-Turner
AA-Turner merged commit e7c5f60 into python:main Apr 19, 2025
@AA-Turner
AA-Turner deleted the fix-textwrap-error branch April 19, 2025 15:18
@bedevere-app bedevere-app Bot removed the awaiting merge label Apr 19, 2025
@hugovk hugovk mentioned this pull request Dec 28, 2025
gh-130167: Add a What's New entry for changes to textwrap.{de,in}dent #131924
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@picnixz picnixz picnixz approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@AA-Turner @hroncok @picnixz
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.