GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Update entry for Willow Chargin in `.mailmap` and `ACKS` by wchargin · Pull Request #132714 · python/cpython

Conversation

@wchargin

@wchargin wchargin commented Apr 19, 2025

Copy link
Copy Markdown
Contributor

No description provided.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@wchargin
mailmap, acks: update Willow Chargin
6219774
@wchargin
wchargin requested a review from a team as a code owner April 19, 2025 02:21
@bedevere-app bedevere-app Bot added the awaiting review label Apr 19, 2025
@wchargin

wchargin commented Apr 19, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

I've already updated my bpo profile. You can see my name on my website here to confirm: https://wchargin.com

I think that this should be "skip issue" and "skip news".

Prior art: #103696

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@StanFromIreland StanFromIreland mentioned this pull request Apr 19, 2025
Exclude .mailmap in Codeowners #132722
Merged
@zware zware added skip issue skip news labels Apr 19, 2025
picnixz
picnixz approved these changes Apr 19, 2025
View reviewed changes
Comment thread .mailmap Resolved

Uh oh!

There was an error while loading. Please reload this page.

@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Apr 19, 2025
@picnixz

picnixz commented Apr 19, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

For posterity: https://github.com/python/cpython/commits?author=wchargin and 674935b for the commit that added the original line in ACKS.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@picnixz picnixz changed the title mailmap, acks: update Willow Chargin Update entry for Willow Chargin in .mailmap and ACKS Apr 19, 2025
@wchargin
[wchargin-mailmap: alphabetize by last name, not full name]
84919e0
picnixz
picnixz approved these changes Apr 19, 2025
View reviewed changes
@picnixz
picnixz enabled auto-merge (squash) April 19, 2025 14:33
@picnixz
picnixz merged commit c821b71 into python:main Apr 19, 2025
@bedevere-app bedevere-app Bot removed the awaiting merge label Apr 19, 2025
@wchargin
wchargin deleted the wchargin-mailmap branch April 19, 2025 14:51
@wchargin

wchargin commented Apr 19, 2025

Copy link
Copy Markdown
Contributor Author

Thank you for the prompt review and merge. @picnixz, a request: I'd prefer if you didn't use my old name in your comment above. Separating myself from that name is the point of this change; I don't want to introduce new search results with the old name, or make it more likely for people who have only known me by my current name to stumble across the old one. Mentioning the original commit is totally fine with me—cross-referencing is good hygiene—but the deadnaming is unnecessary.

Thanks again.

(I tried to send this note by email, but I couldn't find contact info.)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@picnixz

picnixz commented Apr 19, 2025

Copy link
Copy Markdown
Member

Sorry for that! I've updated my comment to remove your old name.

wchargin reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@picnixz picnixz picnixz approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@wchargin @picnixz @zware
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.