GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.13] gh-132578: Rename the `threading.Thread._handle` field (GH-132696) by miss-islington · Pull Request #132789 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Apr 21, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Commit 0e9c364f introduced the _handle field on instances of
threading.Thread. Unfortunately it's fairly common for subclasses
of threading.Thread to define a _handle() method, which is shadowed
by the new field.
(cherry picked from commit 3cfab44)

Co-authored-by: mpage [email protected]

  • Issue: Introduction of Thread._handle: _thread._ThreadHandle in Python3.13 has broken an unknown number of packages #132578

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@mpage @miss-islington
pythongh-132578: Rename the threading.Thread._handle field (pythonG…
d59d1d5 
…H-132696)

Commit `0e9c364f` introduced the `_handle` field on instances of
`threading.Thread`. Unfortunately it's fairly common for subclasses
of `threading.Thread` to define a `_handle()` method, which is shadowed
by the new field.
(cherry picked from commit 3cfab44)

Co-authored-by: mpage <[email protected]>
@bedevere-app bedevere-app Bot added the awaiting review label Apr 21, 2025
This was referenced Apr 21, 2025
Introduction of Thread._handle: _thread._ThreadHandle in Python3.13 has broken an unknown number of packages #132578
Open
gh-132578: Rename the threading.Thread._handle field #132696
Merged
@Yhg1s Yhg1s added the DO-NOT-MERGE label Apr 21, 2025
@Yhg1s

Yhg1s commented Apr 21, 2025

Copy link
Copy Markdown
Member

Let's hold off on merging this until we've got a clearer picture of the extent of the breakage and the risk of this change. (See #132696 (comment))
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@hellypi hellypi mentioned this pull request May 18, 2025
Python 3.14 and above broke the debug extension microsoft/debugpy#1893
Closed
@hellypi

hellypi commented May 18, 2025

Copy link
Copy Markdown

Let's hold off on merging this until we've got a clearer picture of the extent of the breakage and the risk of this change. (See #132696 (comment))

You broke every package that was relying on _handle not being a shadowing, so we are past the stage of worrying about breaking previously unbroken libraries. There currently is a way smaller amount of packages that rely on _handle. I would argue for renaming as soon as possible, since newly created packages are more likely to still be maintained compared to older packages.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@lancelote lancelote mentioned this pull request May 21, 2025
add Python 3.14 compatible logic to check if a thread is alive fabioz/PyDev.Debugger#305
Open
@ToninoK ToninoK mentioned this pull request Jun 24, 2025
AttributeError in threading.py for Python 3.13.5 gevent/gevent#2120
Closed
@embray embray mentioned this pull request Jul 1, 2025
set thread._handle to None for python <= 3.13 gevent/gevent#2117
Closed
@arcivanov arcivanov mentioned this pull request Aug 1, 2025
_DummyThread object has no attribute '_handle` with Python 3.13.5 gevent/gevent#2119
Closed
pablogsal
pablogsal approved these changes Jan 25, 2026
View reviewed changes
@pablogsal
pablogsal enabled auto-merge (squash) January 25, 2026 17:09
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Jan 25, 2026
@pablogsal

pablogsal commented Jan 25, 2026

Copy link
Copy Markdown
Member

Disregard the approve, pressed the button in the wrong PR
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@picnixz
picnixz disabled auto-merge January 28, 2026 10:03
@github-actions

github-actions Bot commented Apr 23, 2026

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Apr 23, 2026
@vstinner

vstinner commented Jun 19, 2026

Copy link
Copy Markdown
Member

This backport PR is open for 1 year. IMO it's not too late to merge it. Developers had enough time to update their code to manage the _handle name conflict.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot removed the stale Stale PR or inactive for long period of time. label Jun 21, 2026
@kumaraditya303

kumaraditya303 commented Jul 13, 2026

Copy link
Copy Markdown
Contributor

Agreed, closing it.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@kumaraditya303 kumaraditya303 closed this Jul 13, 2026
@miss-islington
miss-islington deleted the backport-3cfab44-3.13 branch July 13, 2026 09:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal pablogsal approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting merge DO-NOT-MERGE

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@miss-islington @Yhg1s @hellypi @pablogsal @vstinner @kumaraditya303 @mpage
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.