GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-87859: Track Code Object Local Kinds For Arguments by ericsnowcurrently · Pull Request #132980 · python/cpython

Conversation

@ericsnowcurrently

@ericsnowcurrently ericsnowcurrently commented Apr 25, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Doing this was always the intention. I was finally motivated to find the time to do it.

See #87859 (comment).

  • Issue: Logically merge cell and locals array. They are already contiguous in memory #87859

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ericsnowcurrently
Track code object local kinds for arguments.
1ffdc1b
@ericsnowcurrently ericsnowcurrently added the skip news label Apr 25, 2025
@ericsnowcurrently
ericsnowcurrently requested review from iritkatriel and markshannon as code owners April 25, 2025 23:10
@bedevere-app bedevere-app Bot added the awaiting core review label Apr 25, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Apr 25, 2025
Logically merge cell and locals array. They are already contiguous in memory #87859
Closed
iritkatriel
iritkatriel reviewed Apr 28, 2025
View reviewed changes
Comment thread Python/assemble.c Outdated
PyErr_NoMemory();
return ERROR;
}
int numargvars = 0;

@iritkatriel iritkatriel Apr 28, 2025

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to move this new code to after kinds was calculated, and then you don't need to allocate the argkinds array (just modify the kinds array)?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@ericsnowcurrently ericsnowcurrently Apr 28, 2025

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I can make that work without slowing things down.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@ericsnowcurrently ericsnowcurrently Apr 29, 2025

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@iritkatriel

iritkatriel commented Apr 28, 2025

Copy link
Copy Markdown
Member

We should add a test for the new flags.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
ericsnowcurrently added 3 commits April 28, 2025 17:32
@ericsnowcurrently
Merge branch 'main' into track-arg-local-kinds
77255be
@ericsnowcurrently
Avoid allocating temporary memory.
6d22d3b
@ericsnowcurrently
Add tests.
144b98d
@ericsnowcurrently
ericsnowcurrently enabled auto-merge (squash) April 29, 2025 01:50
@ericsnowcurrently
ericsnowcurrently merged commit 219d8d2 into python:main Apr 29, 2025
@bedevere-app bedevere-app Bot removed the awaiting core review label Apr 29, 2025
@ericsnowcurrently
ericsnowcurrently deleted the track-arg-local-kinds branch April 29, 2025 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@iritkatriel iritkatriel iritkatriel left review comments
@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@ericsnowcurrently @iritkatriel
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.