GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-132983: Convert compression._common to a package by vstinner · Pull Request #133086 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Apr 28, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Add an __init__ file. Fix test_tools.test_freeze.

  • Issue: Implement PEP 784 - Adding Zstandard to the Python standard library #132983

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
pythongh-132983: Convert compression._common to a package
0789ab8 
Add an __init__ file. Fix test_tools.test_freeze.
@vstinner vstinner added the skip news label Apr 28, 2025
@bedevere-app bedevere-app Bot added the awaiting core review label Apr 28, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Apr 28, 2025
Implement PEP 784 - Adding Zstandard to the Python standard library #132983
Closed
13 tasks done
@vstinner vstinner mentioned this pull request Apr 28, 2025
gh-132983: Install compression package contents #133063
Merged
@vstinner

vstinner commented Apr 28, 2025

Copy link
Copy Markdown
Member Author

cc @emmatyping @freakboy3742 @picnixz @JelleZijlstra
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
JelleZijlstra
JelleZijlstra approved these changes Apr 28, 2025
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Apr 28, 2025
@vstinner
vstinner enabled auto-merge (squash) April 28, 2025 14:04
emmatyping
emmatyping approved these changes Apr 28, 2025
View reviewed changes

@emmatyping emmatyping left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@picnixz

picnixz commented Apr 28, 2025

Copy link
Copy Markdown
Member

I'll close #133076 then
emmatyping reacted with heart emoji
All reactions
  • ❤️ 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@emmatyping

emmatyping commented Apr 28, 2025

Copy link
Copy Markdown
Member

Should we also consider the module finder error a bug? Perhaps it would be good to file an issue for it?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
vstinner merged commit fe8ad53 into python:main Apr 28, 2025
@vstinner
vstinner deleted the fix_freeze branch April 28, 2025 14:13
@bedevere-app bedevere-app Bot removed the awaiting merge label Apr 28, 2025
@vstinner

vstinner commented Apr 28, 2025

Copy link
Copy Markdown
Member Author

Should we also consider the module finder error a bug? Perhaps it would be good to file an issue for it?

Honestly, I don't know. I just wrote a change to fix buildbots :-)
emmatyping reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra approved these changes
@emmatyping emmatyping emmatyping approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@vstinner @picnixz @emmatyping @JelleZijlstra
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.