GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — Reference zipimport source code from docs by tirkarthi · Pull Request #13310 · python/cpython

Conversation

@tirkarthi

@tirkarthi tirkarthi commented May 14, 2019

Copy link
Copy Markdown
Member

zipimport module is written in Python so reference the source code from docs.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@tirkarthi
Reference zipimport source code from docs
76a3181
@the-knights-who-say-ni the-knights-who-say-ni added the CLA signed label May 14, 2019
@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels May 14, 2019
@tirkarthi

tirkarthi commented May 14, 2019

Copy link
Copy Markdown
Member Author

cc @serhiy-storchaka : zipimport was rewritten in Python with #6809
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
serhiy-storchaka
serhiy-storchaka approved these changes May 14, 2019
View reviewed changes
@bedevere-bot bedevere-bot added awaiting merge and removed awaiting review labels May 14, 2019
@matrixise matrixise added skip issue skip news labels May 15, 2019
@matrixise

matrixise commented May 15, 2019

Copy link
Copy Markdown
Member

@serhiy-storchaka Do you want to merge this PR?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@serhiy-storchaka
serhiy-storchaka merged commit e307e5c into python:master May 15, 2019
@bedevere-bot bedevere-bot removed the awaiting merge label May 15, 2019
@tirkarthi
tirkarthi deleted the add-zipimport-source-docs branch May 26, 2019 04:26
@tirkarthi
tirkarthi restored the add-zipimport-source-docs branch September 27, 2019 04:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

docs Documentation in the Doc dir skip issue skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

5 participants

@tirkarthi @matrixise @serhiy-storchaka @the-knights-who-say-ni @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.