GeezerVison is showing github.com — gh-133351: Fix Cmd completion for lines beginning with `! ` by godlygeek · Pull Request #133362 · python/cpython
Conversation
godlygeek
commented
May 4, 2025
•
edited by bedevere-app
Bot
Loading
Uh oh!
There was an error while loading. Please reload this page.
When a line begins with ! and there's no do_shell method defined, parsecmd returns None as the cmd, which incorrectly leads to None being concatenated to complete_ and triggering a TypeError.
Instead, recognize None as a sentinel that means we should call completedefault, as an empty string already is.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
When a line begins with `!` and there's no `do_shell` method defined,
`parsecmd` returns `None` as the `cmd`, which incorrectly leads to
`None` being concatenated to `complete_` and triggering a `TypeError`.
Instead, recognize `None` as a sentinel that means we should call
`completedefault`, as an empty string already is.
|
Actually, let me close this and open a new issue for it, since this probably deserves a real news entry unrelated to PDB...
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
You can just change the gh issue number.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
Too late, I wasn't sure so I opened #133364 😓
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.