GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.13] bpo-44172: Keep reference to original window in curses subwindow objects (GH-26226) by serhiy-storchaka · Pull Request #133370 · python/cpython

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented May 4, 2025

Copy link
Copy Markdown
Member

The X/Open curses specification[0] and ncurses documentation[1] both state that subwindows must be deleted before the main window.

Deleting the windows in the wrong order causes a double-free with NetBSD's curses implementation.

To fix this, keep track of the original window object in the subwindow object, and keep a reference to the original for the lifetime of the subwindow.

[0] https://pubs.opengroup.org/onlinepubs/7908799/xcurses/delwin.html [1] https://invisible-island.net/ncurses/man/curs_window.3x.html (cherry picked from commit 0af61fe)

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@michaelforney @serhiy-storchaka
[3.13] bpo-44172: Keep reference to original window in curses subwind…
a4ebf5d
…ow objects (pythonGH-26226)

The X/Open curses specification[0] and ncurses documentation[1]
both state that subwindows must be deleted before the main window.

Deleting the windows in the wrong order causes a double-free with
NetBSD's curses implementation.

To fix this, keep track of the original window object in the subwindow
object, and keep a reference to the original for the lifetime of
the subwindow.

[0] https://pubs.opengroup.org/onlinepubs/7908799/xcurses/delwin.html
[1] https://invisible-island.net/ncurses/man/curs_window.3x.html
(cherry picked from commit 0af61fe)

Co-authored-by: Michael Forney <[email protected]>
Co-authored-by: Serhiy Storchaka <[email protected]>
@bedevere-app bedevere-app Bot added the awaiting core review label May 4, 2025
@bedevere-app bedevere-app Bot mentioned this pull request May 4, 2025
bpo-44172: Keep reference to original window in curses subwindow objects #26226
Merged
@serhiy-storchaka
serhiy-storchaka enabled auto-merge (squash) May 4, 2025 10:52
@serhiy-storchaka
serhiy-storchaka merged commit 3c9d177 into python:3.13 May 4, 2025
@bedevere-app bedevere-app Bot removed the awaiting core review label May 4, 2025
@serhiy-storchaka
serhiy-storchaka deleted the backport-0af61fe-3.13 branch May 4, 2025 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@serhiy-storchaka @michaelforney
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.