GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.13] gh-122559: Synchronize C and Python implementation of the io module about pickling (GH-122628) by serhiy-storchaka · Pull Request #133381 · python/cpython

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented May 4, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

In the C implementation, remove reduce and reduce_ex methods that always raise TypeError and restore getstate methods that always raise TypeErrori.

This restores fine details of the pre-3.12 behavior and unifies both implementations.
(cherry picked from commit e9253eb)

  • Issue: Pickle ignores custom getstate methods on TextIOWrapper in Python 3.12 #122559

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@serhiy-storchaka
[3.13] pythongh-122559: Synchronize C and Python implementation of th…
4f0dbd0
…e io module about pickling (pythonGH-122628)

In the C implementation, remove __reduce__ and __reduce_ex__ methods
that always raise TypeError and restore __getstate__ methods that always
raise TypeErrori.

This restores fine details of the pre-3.12 behavior and unifies
both implementations.
(cherry picked from commit e9253eb)

Co-authored-by: Serhiy Storchaka <[email protected]>
@bedevere-app bedevere-app Bot mentioned this pull request May 4, 2025
Pickle ignores custom getstate methods on TextIOWrapper in Python 3.12 #122559
Closed
@bedevere-app bedevere-app Bot added the awaiting core review label May 4, 2025
@bedevere-app bedevere-app Bot mentioned this pull request May 4, 2025
gh-122559: Synchronize C and Python implementation of the io module about pickling #122628
Merged
@serhiy-storchaka
serhiy-storchaka enabled auto-merge (squash) May 4, 2025 15:42
@serhiy-storchaka
serhiy-storchaka merged commit 973e2d3 into python:3.13 May 4, 2025
@bedevere-app bedevere-app Bot removed the awaiting core review label May 4, 2025
@serhiy-storchaka
serhiy-storchaka deleted the backport-e9253eb-3.13 branch July 1, 2026 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@serhiy-storchaka
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.