GeezerVison is showing github.com — gh-131798: JIT: Narrow the return type of _BINARY_SLICE to original container type by Zheaoli · Pull Request #133527 · python/cpython
Conversation
Zheaoli
commented
May 6, 2025
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
I'm not sure this patch will take some effect.
In my original thought, I think if we can setup the return type to the original container type(tuple, list etc.), the optimizer will specialize some code in the test.
but the test is not work on my thought. I guess I miss something important here. cc @brandtbucher @Fidget-Spinner
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
@Zheaoli, I appreciate you taking the time to do this, but somebody else is already working on _BINARY_SLICE. Part of the reason I created an issue for this was so we could coordinate the work, rather than having multiple people racing on the same tasks.
Is it okay if we close this? FYI, one issue I see here is that there is no guarantee that slicing an arbitrary object will give you the same class (we need to check for some common classes instead):
>>> import mmap
>>> mm = mmap.mmap(-1, 42)
>>> type(mm)
<class 'mmap.mmap'>
>>> type(mm[:])
<class 'bytes'>
|
Zheaoli reacted with heart emoji
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
I appreciate you taking the time to do this, but somebody else is already working on _BINARY_SLICE. Part of the reason I created an issue for this was so we could coordinate the work, rather than having multiple people racing on the same tasks.
Sorry about this! I have not noticed this has been assigned.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Is it okay if we close this?
Sure!
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
one issue I see here is that there is no guarantee that slicing an arbitrary object will give you the same class (we need to check for some common classes instead):
Thanks about the explain. You prove one of my guess.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.