GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-131798: JIT: Assign type to sliced string by fluhus · Pull Request #133609 · python/cpython

Conversation

@fluhus

@fluhus fluhus commented May 7, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Slicing a string always returns a string.
Make the optimizer assign a string type to the result of slicing a string.

Follow up to-do: apply this to lists and tuples too.

@brandtbucher

  • Issue: Better uop coverage in the JIT optimizer #131798

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
fluhus added 2 commits May 7, 2025 12:42
@fluhus
JIT: Assign type to sliced string
9967aea
@fluhus
Revert accidental whitespace change
7f64a64
@fluhus
fluhus requested a review from Fidget-Spinner as a code owner May 7, 2025 19:49
@bedevere-app bedevere-app Bot mentioned this pull request May 7, 2025
Better uop coverage in the JIT optimizer #131798
Open
@bedevere-app bedevere-app Bot added the awaiting review label May 7, 2025
@fluhus
Merge branch 'python:main' into amit
03b932f
sharktide
sharktide suggested changes May 8, 2025
View reviewed changes

@sharktide sharktide left a comment •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a user-facing change. This probably needs a NEWS entry

*sorry, this isn't a user-facing change. I was tired and not thinking straight. But still would be best for a news entry

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting core review and removed awaiting review labels May 8, 2025
@brandtbucher

brandtbucher commented May 8, 2025

Copy link
Copy Markdown
Member

This isn’t a user-facing change (but a NEWS entry doesn’t hurt).
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sharktide

sharktide commented May 8, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

This isn’t a user-facing change (but a NEWS entry doesn’t hurt).

sorry, did I type that? my brain wasn't working. Yes, you're right, a news entry would be best here and this isn't a user facing change.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
brandtbucher
brandtbucher approved these changes May 8, 2025
View reviewed changes
Comment thread Python/optimizer_bytecodes.c
Comment on lines +1100 to +1102
// Slicing a string always returns a string.
// TODO: We can apply this to lists and tuples as well.
// We'll start with string to simplify the process.

@brandtbucher brandtbucher May 8, 2025

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wanna just add the others to this PR too? It's just two lines here and a couple of tests.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels May 8, 2025
sharktide
sharktide approved these changes May 8, 2025
View reviewed changes
@fluhus fluhus closed this May 25, 2025
@fluhus
fluhus deleted the amit branch May 25, 2025 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@brandtbucher brandtbucher brandtbucher approved these changes
@Fidget-Spinner Fidget-Spinner Awaiting requested review from Fidget-Spinner Fidget-Spinner is a code owner
+1 more reviewer
@sharktide sharktide sharktide approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting merge

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@fluhus @brandtbucher @sharktide
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.