GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-133677: Skip test in `test_httpservers` if not utf-8 by StanFromIreland · Pull Request #133706 · python/cpython

Conversation

@StanFromIreland

@StanFromIreland StanFromIreland commented May 8, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Several tests fail when system encoding is latin-1 #133677

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@StanFromIreland
Skip test if not utf-8
302127f
@bedevere-app bedevere-app Bot added the tests Tests in the Lib/test dir label May 8, 2025
@bedevere-app bedevere-app Bot mentioned this pull request May 8, 2025
Several tests fail when system encoding is latin-1 #133677
Closed
@bedevere-app bedevere-app Bot added the awaiting review label May 8, 2025
@StanFromIreland
more import
e45a58d
@StanFromIreland

StanFromIreland commented May 8, 2025

Copy link
Copy Markdown
Member Author

Calling the raspbian buildbots would verify this is solved.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@sharktide

sharktide commented May 8, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

@StanFromIreland Is it okay if I handle the zipfile test fail? I worked alot with the zipfile lib
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
This was referenced May 8, 2025
gh-133677 Skip test in test_zipfile if not UTF-8 #133715
Closed
gh-133677: Skip test in test_asyncio if not UTF-8 #133719
Closed
@ZeroIntensity

ZeroIntensity commented May 8, 2025

Copy link
Copy Markdown
Member

!buildbot raspbian
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented May 8, 2025

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @ZeroIntensity for commit e45a58d 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F133706%2Fmerge

The command will test the builders whose names match following regular expression: raspbian

The builders matched are:

  • ARM64 Raspbian PR
  • ARM Raspbian PR
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ZeroIntensity ZeroIntensity added the skip news label May 8, 2025
@StanFromIreland

StanFromIreland commented May 9, 2025

Copy link
Copy Markdown
Member Author

Test passes on buildbot.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
zware
zware reviewed May 9, 2025
View reviewed changes
Comment thread Lib/test/test_httpservers.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
StanFromIreland added 2 commits May 9, 2025 16:18
@StanFromIreland
Fixup
d1ab24c
@StanFromIreland
fixup fixup
6f951b7
@StanFromIreland
StanFromIreland requested a review from zware May 9, 2025 15:19
zware
zware reviewed May 9, 2025
View reviewed changes
Comment thread Lib/test/test_httpservers.py Outdated
response = self.request(self.base_url + '/?x=123').read()
self.assertRegex(response, rf'listing for {self.base_url}/\?x=123'.encode('latin1'))
# now the bogus encoding
# now the bogus (utf-8) encoding

@zware zware May 9, 2025

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment should be reverted as well.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@sharktide

sharktide commented May 9, 2025

Copy link
Copy Markdown
Contributor

@zware please review #133715 since it directly correlates to this PR
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@StanFromIreland
Revert comment change
f1a67dc
@StanFromIreland
StanFromIreland requested a review from zware May 9, 2025 19:43
@serhiy-storchaka

serhiy-storchaka commented May 11, 2025

Copy link
Copy Markdown
Member

Sorry, but skipping the test is not a proper fix of this issue. Test failure exposes a bug in http.server.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@serhiy-storchaka serhiy-storchaka closed this May 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@zware zware Awaiting requested review from zware

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@StanFromIreland @sharktide @ZeroIntensity @bedevere-bot @serhiy-storchaka @zware
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.