GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.13] gh-133439: Fix dot commands with trailing spaces are mistaken for multi-line sqlite statements in the sqlite3 command-line interface (GH-133440) by tanloong · Pull Request #133765 · python/cpython

Conversation

@tanloong

@tanloong tanloong commented May 9, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

(cherry picked from commit ebd4881)

  • Issue: sqlite3 CLI does not recognize dot commands with trailing spaces #133439

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@tanloong
tanloong requested review from berkerpeksag and erlend-aasland as code owners May 9, 2025 14:44
@bedevere-app bedevere-app Bot mentioned this pull request May 9, 2025
sqlite3 CLI does not recognize dot commands with trailing spaces #133439
Closed
@bedevere-app bedevere-app Bot added the awaiting review label May 9, 2025
@bedevere-app bedevere-app Bot mentioned this pull request May 9, 2025
gh-133439: Fix dot commands with trailing spaces are mistaken for multi-line sqlite statements in the sqlite3 command-line interface #133440
Merged
tanloong added 2 commits May 9, 2025 23:12
@tanloong
pythongh-133439: Fix dot commands with trailing spaces are mistaken f…
771f617 
…or multi-line sqlite statements in the sqlite3 command-line interface (pythonGH-133440)

(cherry picked from commit ebd4881)
@tanloong
Fix tests
62d4719
@tanloong
tanloong force-pushed the 3.13 branch from 0741f45 to 62d4719 Compare May 9, 2025 15:12
picnixz
picnixz reviewed May 10, 2025
View reviewed changes
Comment thread Lib/test/test_sqlite3/test_cli.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
tanloong added 3 commits May 10, 2025 17:00
@tanloong
Revert "Fix tests"
23e4b3c 
This reverts commit 62d4719.
@tanloong
Use assertEndsWith from test.support.testcase.ExtraAssertions
2cd00c4
@tanloong
Fix tests: mix in ExtraAssertions to InteractiveSession
2f74e65
picnixz
picnixz reviewed May 10, 2025
View reviewed changes
Comment thread Lib/test/test_sqlite3/test_cli.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@tanloong
Revert changes unrelated to the original PR
22d2b27
serhiy-storchaka
serhiy-storchaka reviewed May 10, 2025
View reviewed changes
Comment thread Lib/test/test_sqlite3/test_cli.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@tanloong
Remove ExtraAssertions from CommandLineInterface
8899925
@serhiy-storchaka
serhiy-storchaka merged commit 22cf289 into python:3.13 Jun 13, 2025
@bedevere-app bedevere-app Bot removed the awaiting review label Jun 13, 2025
@tanloong
tanloong deleted the 3.13 branch May 1, 2026 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka left review comments
@picnixz picnixz picnixz left review comments
@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag
@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@tanloong @serhiy-storchaka @picnixz
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.