GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.14] gh-132641: fix race in `lru_cache` under free-threading (GH-133787) by miss-islington · Pull Request #133979 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented May 13, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Fix race in lru_cache by acquiring critical section on the cache object itself and call the lock held variant of dict functions to modify the underlying dict.
(cherry picked from commit 9ad0c7b)

Co-authored-by: Peter Hawkins [email protected]

  • Issue: Data race between compare_generic and insert_combined_dict under free-threading #132641

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@hawkinsp @miss-islington
pythongh-132641: fix race in lru_cache under free-threading (python…
1594c26 
…GH-133787)

Fix race in `lru_cache` by acquiring critical section on the cache object itself and call the lock held variant of dict functions to modify the underlying dict.
(cherry picked from commit 9ad0c7b)

Co-authored-by: Peter Hawkins <[email protected]>
@miss-islington
miss-islington requested review from markshannon, methane and rhettinger as code owners May 13, 2025 17:39
This was referenced May 13, 2025
Data race between compare_generic and insert_combined_dict under free-threading #132641
Closed
gh-132641: fix race in lru_cache under free-threading #133787
Merged
@bedevere-app bedevere-app Bot added topic-free-threading awaiting review labels May 13, 2025
kumaraditya303
kumaraditya303 approved these changes May 13, 2025
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels May 13, 2025
@kumaraditya303
kumaraditya303 enabled auto-merge (squash) May 13, 2025 17:39
@rhettinger
rhettinger requested review from serhiy-storchaka and removed request for rhettinger May 13, 2025 20:38
serhiy-storchaka
serhiy-storchaka approved these changes May 14, 2025
View reviewed changes
@kumaraditya303
kumaraditya303 merged commit 66d6860 into python:3.14 May 14, 2025
@bedevere-app bedevere-app Bot removed the awaiting merge label May 14, 2025
@miss-islington
miss-islington deleted the backport-9ad0c7b-3.14 branch January 2, 2026 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes
@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes
@methane methane Awaiting requested review from methane methane is a code owner
@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

topic-free-threading

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@miss-islington @serhiy-storchaka @kumaraditya303 @hawkinsp
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.