GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-133885: Disallow sharing zstd (de)compressor contexts by emmatyping · Pull Request #134253 · python/cpython

Conversation

@emmatyping

@emmatyping emmatyping commented May 19, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

It is not possible to share Zstandard objects across thread boundaries. To resolve this, we check if the object was created on the current thread and raise a RuntimeError if it is not. Wasn't totally sure what exception to raise to communicate the issue, so if RuntimeError isn't correct, please suggestion another option.

The tests are updated to ensure that the error is raised if a (de)compression context is shared across threads.

(as requested, cc @ngoldbaum )

  • Issue: test_zstd failed on ubuntu with free-threading #133885

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@emmatyping
Disallow sharing zstd (de)compressor contexts
1c3071d
According to the zstd author, it is not possible to share Zstandard objects across thread boundaries. To resolve this, we check if the object was created on the current thread and raise a RuntimeError if it is not.

The tests are updated to ensure that the error is raised if a (de)compression context is shared across threads.
@emmatyping emmatyping added skip news needs backport to 3.14 bugs and security fixes labels May 19, 2025
@bedevere-app bedevere-app Bot mentioned this pull request May 19, 2025
test_zstd failed on ubuntu with free-threading #133885
Closed
@bedevere-app bedevere-app Bot added the awaiting review label May 19, 2025
@emmatyping
Merge branch 'main' into zstd-unsharable-de-compressor
8620ea3
@emmatyping emmatyping closed this May 19, 2025
@emmatyping emmatyping reopened this May 19, 2025
gpshead
gpshead reviewed May 19, 2025
View reviewed changes
Comment thread Modules/_zstd/_zstdmodule.h
int key_v, int value_v);

static inline int
check_object_shared(PyObject *ob, char *type)

@gpshead gpshead May 19, 2025

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is probably not be the right way to implement this check? Access from different threads could happen regardless of free-threading builds.

I think the concept the extension module might want to enforce is something like getting the current thread id (we have a python c api for this IIRC) upon first "use" of the object, saving that in the object state, and checking that current thread id == that thread id for subsequent uses.

first use could be construction... but unless the zstandard C API requires that, it may be better to consider first use the first time that ZStdCompressor is actually used by a C API. This allows for the pattern of:

A compressor or decompressor is created by one thread - and added to a thread pool or work queue to be actually used and exhausted - exclusively - in another thread.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@emmatyping

emmatyping commented May 19, 2025

Copy link
Copy Markdown
Member Author

After talking with Thomas, I think I'm going to try a different approach.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@emmatyping emmatyping closed this May 19, 2025
@AA-Turner AA-Turner removed the needs backport to 3.14 bugs and security fixes label Aug 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpshead gpshead gpshead left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@emmatyping @gpshead @AA-Turner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.