GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.14] gh-128639: Don't assume one thread in subinterpreter finalization (gh-128640) by miss-islington · Pull Request #134254 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented May 19, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Incidentally, this also fixed the warning not showing up if a subinterpreter wasn't
cleaned up via _interpreters.destroy. I had to update some of the tests as a result.
(cherry picked from commit 9859791)

Co-authored-by: Peter Bierma [email protected]

  • Issue: Subinterpreters don't properly clean up threads #128639

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ZeroIntensity @miss-islington
pythongh-128639: Don't assume one thread in subinterpreter finalizati…
76bcc46 
…on (pythongh-128640)

Incidentally, this also fixed the warning not showing up if a subinterpreter wasn't
cleaned up via _interpreters.destroy. I had to update some of the tests as a result.
(cherry picked from commit 9859791)

Co-authored-by: Peter Bierma <[email protected]>
@miss-islington
miss-islington requested a review from ericsnowcurrently as a code owner May 19, 2025 16:57
@bedevere-app bedevere-app Bot mentioned this pull request May 19, 2025
Subinterpreters don't properly clean up threads #128639
Closed
@bedevere-app bedevere-app Bot added the topic-subinterpreters label May 19, 2025
@bedevere-app bedevere-app Bot mentioned this pull request May 19, 2025
gh-128639: Don't assume one thread in subinterpreter finalization #128640
Merged
@bedevere-app bedevere-app Bot added the awaiting review label May 19, 2025
@hugovk

hugovk commented May 19, 2025

Copy link
Copy Markdown
Member

Let's check the buildbot failure before merging this: #128640 (comment)
ericsnowcurrently reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ZeroIntensity ZeroIntensity added the DO-NOT-MERGE label May 19, 2025
@ZeroIntensity

ZeroIntensity commented May 19, 2025

Copy link
Copy Markdown
Member

That failure looks related, but I have absolutely no idea how.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented May 19, 2025

Copy link
Copy Markdown
Member

I suppose that this change should not be merged, since you proposed a revert for the same change in the main branch: #134256
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ZeroIntensity

ZeroIntensity commented May 21, 2025

Copy link
Copy Markdown
Member

!buildbot iOS
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented May 21, 2025

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @ZeroIntensity for commit 76bcc46 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F134254%2Fmerge

The command will test the builders whose names match following regular expression: iOS

The builders matched are:

  • iOS ARM64 Simulator PR
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ZeroIntensity

ZeroIntensity commented May 21, 2025

Copy link
Copy Markdown
Member

I'm going to run the buildbots to see if the crash is somehow related to something else on 3.15. I'm still pretty lost on what could be the cause. I can only see two possibilities:

  • We revealed an existing bug with _PyThreadState_DeleteList and/or _PyThreadState_RemoveExcept.
  • The embedding test revealed a bug with the implementation, but I'm not sure what. Maybe I broke destroying interpreters with only one thread state?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mhsmith

mhsmith commented May 21, 2025

Copy link
Copy Markdown
Member

I'm not sure if it's related, but the iOS buildbot has also been experiencing another intermittent subinterpreters failure: #127108. The most recent instance was in #125962 (comment).
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ZeroIntensity

ZeroIntensity commented May 21, 2025

Copy link
Copy Markdown
Member

In this specific case, the change was related. It's reverted on main. I haven't had time to look into those other failures yet.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ZeroIntensity

ZeroIntensity commented May 24, 2025

Copy link
Copy Markdown
Member

Closing in favor of #134606. We'll backport that one instead.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@ZeroIntensity ZeroIntensity closed this May 24, 2025
@miss-islington
miss-islington deleted the backport-9859791-3.14 branch January 2, 2026 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review DO-NOT-MERGE topic-subinterpreters

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

6 participants

@miss-islington @hugovk @ZeroIntensity @vstinner @bedevere-bot @mhsmith
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.