GeezerVison

I dislike this RuntimeWarning. It's ok to run programs without SystemRoot env var, or even in an empty environment. It just works fine currently for some programs. Example:

import subprocess, sys
cmd = [sys.executable, '-c', 'print("Hello World")']
subprocess.run(cmd, env={})

This program just works, it displays "Hello World" as expected.

I'm not sure how to synthesize this feedback with #134363 (comment).

How do we prevent the problem, if not warning about it, and not setting it in the subprocess? Should we implicitly override the caller's choices and clone SystemRoot into the subprocess env?

I don't think that we have to prevent the problem. We can document it and explain how to avoid it.

Well, it works since Windows decided that using PATH to locate runtime dependencies (like an LD_LIBRARY_PATH equivalent) was such a terrible idea that it bypasses it for most OS stuff, but that "fix" upsets people as well.

I'm not particularly strong either way on this fix. It bites people all the time, and it's practically always a pointless thing to do (pass an insufficient environment). At the same time, there are 5-6 other variables that also ought to be included or things will break weirdly (e.g. TEMP), and this change doesn't check for those. But I don't think we have any good way to only warn when things break.

Is there a silent-by-default-enabled-with-X-dev warning that could be used instead? Would that be okay, @vstinner?

If we add a warning, it may be better to emit the warning in the socket module, no?

Is there a silent-by-default-enabled-with-X-dev warning that could be used instead? Would that be okay, @vstinner?

A warning only emitted in the Python Developer Mode (-X dev) sounds more acceptable to me, yes.

it may be better to emit the warning in the socket module, no?

The user's system could be configured to avoid that error, even without the environment variable, while plenty of other parts could also break if they are reconfigured.

Launching an application with an empty environment is the bad idea, so that's where the warning should be. I've diagnosed that as the root cause of a lot of issues.

Do we have an existing warning? Or do we need to invent a new one? This isn't a deprecation, and that's the only warning I'm aware of.