GeezerVison is showing github.com — gh-127987: Ensure that directories are not renamed during `tar.TarFile.extractall()` by noamcohen97 · Pull Request #134628 · python/cpython
Conversation
noamcohen97
commented
May 24, 2025
•
edited by bedevere-app
Bot
Loading
Uh oh!
There was an error while loading. Please reload this page.
The most straightforward approach to solving this issue is to re-consult the filter_function just before updating the attributes in the directory within extract_all(). However, this would result in stateful extraction filters receiving a redundant call for a file that has already passed the filter.
Inspired by GNU Tar, I decided to save the exact inode number of the created directory to ensure it hasn't changed.
The only downside I can see is that stat() is called shortly after the directory is created, which introduces a race condition. Since the entire module is already susceptible to these kinds of races (the path is resolved in the filter_function and then re-resolved in the actual file creation methods), I believe this is acceptable.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
@sethmlarson Please let me know what your thoughts are on this one
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
it doesn't have to do with this bug
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A news entry would be best here
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
|
This PR is stale because it has been open for 30 days with no activity.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Reviewers
ethanfurman
Awaiting requested review from ethanfurman
ethanfurman will be requested when the pull request is marked ready for review
ethanfurman is a code owner
1 more reviewer
Reviewers whose approvals may not affect merge requirements
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.