GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.10] gh-135034: Normalize link targets in tarfile, add `os.path.realpath(strict='allow_missing')` (GH-135037) by Yhg1s · Pull Request #135070 · python/cpython

Conversation

@Yhg1s

@Yhg1s Yhg1s commented Jun 3, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Addresses CVEs 2024-12718, 2025-4138, 2025-4330, and 2025-4517.
(cherry picked from commit 3612d8f)

Co-authored-by: Łukasz Langa [email protected]
Co-authored-by: Petr Viktorin [email protected]
Co-authored-by: Seth Michael Larson [email protected]
Co-authored-by: Adam Turner [email protected]
Co-authored-by: Serhiy Storchaka [email protected]

  • Issue: Multiple tarfile extraction filter bypasses (filter="tar"/filter="data") #135034

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@ambv @encukou
@sethmlarson @AA-Turner @serhiy-storchaka @Yhg1s
[3.10] pythongh-135034: Normalize link targets in tarfile, add `os.pa…
4d959a0 
…th.realpath(strict='allow_missing')` (pythonGH-135037)

Addresses CVEs 2024-12718, 2025-4138, 2025-4330, and 2025-4517.
(cherry picked from commit 3612d8f)
(cherry picked from commit c358142)
(cherry picked from commit 371b4ea)

Co-authored-by: Łukasz Langa <[email protected]>
Signed-off-by: Łukasz Langa <[email protected]>
Co-authored-by: Petr Viktorin <[email protected]>
Co-authored-by: Seth Michael Larson <[email protected]>
Co-authored-by: Adam Turner <[email protected]>
Co-authored-by: Serhiy Storchaka <[email protected]>
@Yhg1s
Yhg1s requested a review from ethanfurman as a code owner June 3, 2025 12:00
@bedevere-app bedevere-app Bot added the awaiting core review label Jun 3, 2025
This was referenced Jun 3, 2025
gh-135034: Normalize link targets in tarfile, add os.path.realpath(strict='allow_missing') #135037
Merged
Multiple tarfile extraction filter bypasses (filter="tar"/filter="data") #135034
Closed
Yhg1s and others added 12 commits June 3, 2025 14:19
@Yhg1s
Drop the use of :cve:, which isn't supported in 3.11 and earlier.
7c3e0dd
@Yhg1s
Merge branch '3.10' into backport-371b4ea-3.10
9a46249
@Yhg1s
Merge branch '3.10' into backport-371b4ea-3.10
4afe368
@Yhg1s
Undo faulty merge.
aa526c0
@Yhg1s
Fix test_tarfile (for not exporting LinkFallbackError) and remove the
6b6a77a 
non-strict test for unreadable symlinks, whch isn't supported before 3.13.
@Yhg1s
Fix Windows test_ntpath failures.
0aaaeaa
@Yhg1s
Fix merge error in backport.
05d7906
@Yhg1s
Remove backported tests that won't pass in 3.10 and earlier for reasons
ad7b73d 
unrelated to the security fix.
@Yhg1s
Fix merge error.
bf6b637
@encukou
Work around Path.glob() failure in 3.10
dff62a1
@encukou
Complete the backport of ALLOW_MISSING
720038b
@encukou
Remove tests for WASI
bacf333
@encukou

encukou commented Jun 3, 2025

Copy link
Copy Markdown
Member

3.10's Path.glob() fails when getting all files extracted from the "nasty" archive, so I pushed a slightly hacky workaround to the test_tarfile helper. Should be OK for 3.9 & 3.10.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
encukou
encukou approved these changes Jun 3, 2025
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Jun 3, 2025
@ambv
ambv merged commit 9c1110e into python:3.10 Jun 3, 2025
@bedevere-app bedevere-app Bot removed the awaiting merge label Jun 3, 2025
@Yhg1s
Yhg1s deleted the backport-371b4ea-3.10 branch August 13, 2026 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@encukou encukou encukou approved these changes
@ethanfurman ethanfurman Awaiting requested review from ethanfurman ethanfurman is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@Yhg1s @encukou @ambv
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.