GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.12] gh-135034: Remove test_realpath_permission by encukou · Pull Request #135093 · python/cpython

Conversation

@encukou

@encukou encukou commented Jun 3, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

The test was added to 3.13 in gh-110298 with a fix that was never backported to 3.12 and below.

Now the test was backported too eagerly along with other new ntpath tests that passed.
This one was most likely skipped in GHA, it does not pass locally for me.

  • Issue: Multiple tarfile extraction filter bypasses (filter="tar"/filter="data") #135034

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@encukou
[3.12] pythongh-135034: Remove test_realpath_permission
ac560d1 
The test was added in pythongh-110298, with a fix that was never backported
to 3.12 and below.
It was most likely skipped in the GHA run.
@bedevere-app bedevere-app Bot added the tests Tests in the Lib/test dir label Jun 3, 2025
@encukou
encukou marked this pull request as ready for review June 3, 2025 14:28
@bedevere-app bedevere-app Bot mentioned this pull request Jun 3, 2025
Multiple tarfile extraction filter bypasses (filter="tar"/filter="data") #135034
Closed
@bedevere-app bedevere-app Bot added the awaiting core review label Jun 3, 2025
@encukou encukou added skip news and removed awaiting core review labels Jun 3, 2025
@ambv
ambv merged commit 28463db into python:3.12 Jun 3, 2025
@encukou
encukou deleted the remove-test_realpath_permission branch June 3, 2025 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@encukou @ambv
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.