GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.13] gh-133157: fix UBSan failures in `Parser/pegen.c` (GH-134048) by picnixz · Pull Request #135334 · python/cpython

Conversation

@picnixz

@picnixz picnixz commented Jun 10, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

(cherry picked from commit 754e7c9)

  • Issue: UBsan: Remove _Py_NO_SANITIZE_UNDEFINED #133157

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@picnixz
[3.13] pythongh-133157: remove usage of _Py_NO_SANITIZE_UNDEFINED i…
dc805f2 
…n `Parser/pegen.c` (pythonGH-134048)

(cherry picked from commit 754e7c9)

Co-authored-by: Bénédikt Tran <[email protected]>
@picnixz
picnixz requested review from lysnikolaou and pablogsal as code owners June 10, 2025 08:50
@bedevere-app bedevere-app Bot added the awaiting core review label Jun 10, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Jun 10, 2025
gh-133157: remove usage of _Py_NO_SANITIZE_UNDEFINED in Parser/pegen.c #134048
Merged
@bedevere-app bedevere-app Bot added the skip news label Jun 10, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Jun 10, 2025
UBsan: Remove _Py_NO_SANITIZE_UNDEFINED #133157
Closed
pablogsal
pablogsal approved these changes Jun 10, 2025
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Jun 10, 2025
@pablogsal
pablogsal enabled auto-merge (squash) June 10, 2025 09:07
@picnixz
picnixz disabled auto-merge June 10, 2025 09:10
@picnixz

picnixz commented Jun 10, 2025

Copy link
Copy Markdown
Member Author

Hum, actually we didn't use _Py_NO_SANITIZE_UNDEFINED here, so I'll change the commit message
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@picnixz picnixz changed the title [3.13] gh-133157: remove usage of _Py_NO_SANITIZE_UNDEFINED in Parser/pegen.c (GH-134048) [3.13] gh-133157: fix UBSan failures in Parser/pegen.c (GH-134048) Jun 10, 2025
@picnixz
picnixz enabled auto-merge (squash) June 10, 2025 09:11
@picnixz
picnixz merged commit dd7ffdb into python:3.13 Jun 10, 2025
@bedevere-app bedevere-app Bot removed the awaiting merge label Jun 10, 2025
@picnixz
picnixz deleted the backport-754e7c9-3.13 branch June 10, 2025 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pablogsal pablogsal pablogsal approved these changes
@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou lysnikolaou is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@picnixz @pablogsal
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.