GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-131876: extract `_hashlib` helpers into a separate directory [WIP] by picnixz · Pull Request #135341 · python/cpython

Conversation

@picnixz

@picnixz picnixz commented Jun 10, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Unify recognization of message digest names for _hashlib and _hmac #131876

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot mentioned this pull request Jun 10, 2025
Unify recognization of message digest names for _hashlib and _hmac #131876
Open
@picnixz picnixz added the skip news label Jun 10, 2025
@picnixz

picnixz commented Jun 10, 2025

Copy link
Copy Markdown
Member Author

!buildbot FIPS only
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented Jun 10, 2025

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @picnixz for commit c90722e 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F135341%2Fmerge

The command will test the builders whose names match following regular expression: FIPS only

The builders matched are:

  • AMD64 RHEL8 FIPS Only Blake2 Builtin Hash PR
  • AMD64 CentOS9 FIPS Only Blake2 Builtin Hash PR
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@picnixz
picnixz force-pushed the refactor/hashlib/lookup-md-131876 branch from cb8ac17 to b213a79 Compare June 10, 2025 11:32
@picnixz

picnixz commented Jun 10, 2025

Copy link
Copy Markdown
Member Author

Ok. This is too messy. I'll need to think about it differently.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@picnixz
picnixz force-pushed the refactor/hashlib/lookup-md-131876 branch 6 times, most recently from 11b0d3c to 0692ccc Compare June 10, 2025 13:05
@picnixz

picnixz commented Jun 10, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member Author

Ok, for now it seems to work on Linux/macOS. Still need to figure out why it fails on WASI and Windows but I have my little idea.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
picnixz
picnixz commented Jun 10, 2025
View reviewed changes
Comment thread PCbuild/_hashlib.vcxproj.filters Resolved

Uh oh!

There was an error while loading. Please reload this page.
@picnixz
picnixz force-pushed the refactor/hashlib/lookup-md-131876 branch 2 times, most recently from 28067ff to 5f21471 Compare June 14, 2025 11:35
@picnixz
faster CI
94cde64
@picnixz
picnixz force-pushed the refactor/hashlib/lookup-md-131876 branch from 5f21471 to e705d15 Compare June 14, 2025 11:37
@picnixz
extract _hashlib helpers into a separate directory
3dd0a97
@picnixz
picnixz force-pushed the refactor/hashlib/lookup-md-131876 branch 2 times, most recently from 1cb7edb to 3dd0a97 Compare June 14, 2025 12:08
@picnixz

picnixz commented Jun 14, 2025

Copy link
Copy Markdown
Member Author

Ok WASI moments. But Windows works!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
picnixz added 8 commits July 14, 2025 13:04
@picnixz
Merge remote-tracking branch 'upstream/main' into refactor/hashlib/ut…
d8653b7 
…il-headers-131876
@picnixz
post-merge
e0d2e78
@picnixz
post-merge
a8c492d
@picnixz
simplify CI
71a1b8f
@picnixz
simplify CI
a60b5ca
@picnixz
less runs
0845dcf
@picnixz
Merge branch 'main' into refactor/hashlib/util-headers-131876
87f7987
@picnixz
post-merge
7a45a9b
picnixz added 5 commits July 22, 2025 11:52
@picnixz
post-merge
cbaaa40
@picnixz
fix
c653c29
@picnixz
fixup
826af90
@picnixz
fix
2efb676
@picnixz
fixup
972a185
@picnixz
picnixz force-pushed the refactor/hashlib/lookup-md-131876 branch from 1eeae0a to 972a185 Compare July 22, 2025 11:39
@picnixz

picnixz commented Jul 22, 2025

Copy link
Copy Markdown
Member Author

I'm done with my experiments, I'll create a fresh PR to have better commits.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@picnixz picnixz closed this Jul 22, 2025
@picnixz picnixz mentioned this pull request Jul 22, 2025
gh-131876: extract _hashlib helpers into a separate directory #136995
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpshead gpshead Awaiting requested review from gpshead gpshead will be requested when the pull request is marked ready for review gpshead is a code owner
@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently will be requested when the pull request is marked ready for review ericsnowcurrently is a code owner
@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland will be requested when the pull request is marked ready for review erlend-aasland is a code owner
@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner will be requested when the pull request is marked ready for review AA-Turner is a code owner
@emmatyping emmatyping Awaiting requested review from emmatyping emmatyping will be requested when the pull request is marked ready for review emmatyping is a code owner
@itamaro itamaro Awaiting requested review from itamaro itamaro will be requested when the pull request is marked ready for review itamaro is a code owner
@corona10 corona10 Awaiting requested review from corona10 corona10 will be requested when the pull request is marked ready for review corona10 is a code owner
@ezio-melotti ezio-melotti Awaiting requested review from ezio-melotti ezio-melotti will be requested when the pull request is marked ready for review ezio-melotti is a code owner
@hugovk hugovk Awaiting requested review from hugovk hugovk will be requested when the pull request is marked ready for review hugovk is a code owner
@webknjaz webknjaz Awaiting requested review from webknjaz webknjaz will be requested when the pull request is marked ready for review webknjaz is a code owner
@JacobCoffee JacobCoffee Awaiting requested review from JacobCoffee JacobCoffee will be requested when the pull request is marked ready for review JacobCoffee is a code owner
@StanFromIreland StanFromIreland Awaiting requested review from StanFromIreland StanFromIreland will be requested when the pull request is marked ready for review StanFromIreland is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@picnixz @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.