GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-115119: removed implicit fallback to the bundled libmpdec by skirpichev · Pull Request #135568 · python/cpython

Conversation

@skirpichev

@skirpichev skirpichev commented Jun 16, 2025 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Unvendor libmpdec sources #115119

📚 Documentation preview 📚: https://cpython-previews--135568.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
skirpichev and others added 16 commits May 16, 2025 09:35
@skirpichev
pythongh-115119: defer removal of bundled libmpdec to 3.16 (configure…
14266c8 
… changes)
@skirpichev
pythongh-115119: removed implicit fallback to the bundled libmpdec
39d1e6b
@skirpichev
address review: remove runner version downgrade
b328702
@skirpichev
+ use libmpdec-dev from PPA for PHP
94ce315
@skirpichev
Merge branch 'master' into remove-fallback-to-bundled-mpdec/115119
fed39e1
@skirpichev
address review: add --with-libmpdec option
4c98b8d
@skirpichev @vstinner
Update .github/workflows/posix-deps-apt.sh
6cd1730 
Co-authored-by: Victor Stinner <[email protected]>
@skirpichev @hugovk
Apply suggestions from code review
9d29df1 
Co-authored-by: Hugo van Kemenade <[email protected]>
@skirpichev
Merge branch 'master' into remove-fallback-to-bundled-mpdec/115119
b733718
@skirpichev
address review: reorder list in posix-deps-apt.sh
d53bdf3
@skirpichev
address review: expand --with-libmpdec description
c3a1889
@skirpichev
address review: add link to option
45544d9
@skirpichev
Merge branch 'master' into remove-fallback-to-bundled-mpdec/115119
8413e6f
@skirpichev
address review: redo posix-deps-apt.sh workaround (install last)
9690208
@skirpichev
Merge branch 'master' into remove-fallback-to-bundled-mpdec/115119
3f059de
@skirpichev
Revert "address review: add --with-libmpdec option"
2422e7d 
This reverts commit 4c98b8d.
@bedevere-app bedevere-app Bot mentioned this pull request Jun 16, 2025
Unvendor libmpdec sources #115119
Closed
15 tasks done
@skirpichev

skirpichev commented Jun 16, 2025

Copy link
Copy Markdown
Member Author

This is a separate pr, without new --with-libmpdec option, per @vstinner request.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@skirpichev skirpichev mentioned this pull request Jun 16, 2025
gh-115119: removed implicit fallback to the bundled libmpdec #134078
Merged
vstinner
vstinner reviewed Jun 17, 2025
View reviewed changes
Comment thread configure.ac
(deprecated and scheduled for removal in Python 3.15)])])
USE_BUNDLED_LIBMPDEC()])
no system libmpdecimal found; falling back to pure-Python version
for the decimal module])])])

@vstinner vstinner Jun 17, 2025

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be possible to log this message at the end of the configure script? Otherwise, it's easy to miss this message in the middle of the long configure output.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@skirpichev skirpichev Jun 17, 2025

Copy link
Copy Markdown
Member Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll continue in the old pr, as you prefer this version.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@skirpichev skirpichev closed this Jun 17, 2025
@skirpichev
skirpichev deleted the remove-fallback-to-bundled-mpdec/115119-v2 branch June 17, 2025 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner left review comments
@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner will be requested when the pull request is marked ready for review AA-Turner is a code owner
@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland will be requested when the pull request is marked ready for review erlend-aasland is a code owner
@corona10 corona10 Awaiting requested review from corona10 corona10 will be requested when the pull request is marked ready for review corona10 is a code owner
@emmatyping emmatyping Awaiting requested review from emmatyping emmatyping will be requested when the pull request is marked ready for review emmatyping is a code owner
@itamaro itamaro Awaiting requested review from itamaro itamaro will be requested when the pull request is marked ready for review itamaro is a code owner
@ezio-melotti ezio-melotti Awaiting requested review from ezio-melotti ezio-melotti will be requested when the pull request is marked ready for review ezio-melotti is a code owner
@hugovk hugovk Awaiting requested review from hugovk hugovk will be requested when the pull request is marked ready for review hugovk is a code owner
@webknjaz webknjaz Awaiting requested review from webknjaz webknjaz will be requested when the pull request is marked ready for review webknjaz is a code owner
@JacobCoffee JacobCoffee Awaiting requested review from JacobCoffee JacobCoffee will be requested when the pull request is marked ready for review JacobCoffee is a code owner
@StanFromIreland StanFromIreland Awaiting requested review from StanFromIreland StanFromIreland will be requested when the pull request is marked ready for review StanFromIreland is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@skirpichev @vstinner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.