GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.14] gh-127146: Emscripten: Fix pathlib glob_dotdot test (GH-135624) by miss-islington · Pull Request #135653 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Jun 18, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

The Emscripten path resolver uses the same mechanism for resolving ..
at a file system root as for resolving symlinks. This is because
roots don't store their mountpoints. If the parent of a node is itself,
it is a root but it might be a mountpoint in some other file system.

If a path has enough ..'s at the root, it will return ELOOP.
Enough turns out to be 49.
(cherry picked from commit e4ccd46)

Co-authored-by: Hood Chatham [email protected]

  • Issue: Emscripten: Get test suite passing #127146

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@hoodmane @miss-islington
pythongh-127146: Emscripten: Fix pathlib glob_dotdot test (pythonGH-1…
d6a9841
…35624)

The Emscripten path resolver uses the same mechanism for resolving `..`
at a file system root as for resolving symlinks. This is because
roots don't store their mountpoints. If the parent of a node is itself,
it is a root but it might be a mountpoint in some other file system.

If a path has enough `..`'s at the root, it will return ELOOP.
Enough turns out to be 49.
(cherry picked from commit e4ccd46)

Co-authored-by: Hood Chatham <[email protected]>
@miss-islington
miss-islington requested a review from barneygale as a code owner June 18, 2025 03:20
@bedevere-app bedevere-app Bot added awaiting review tests Tests in the Lib/test dir labels Jun 18, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Jun 18, 2025
gh-127146: Emscripten: Fix pathlib glob_dotdot test #135624
Merged
@bedevere-app bedevere-app Bot added the skip news label Jun 18, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Jun 18, 2025
Emscripten: Get test suite passing #127146
Closed
freakboy3742
freakboy3742 approved these changes Jun 18, 2025
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Jun 18, 2025
@freakboy3742
freakboy3742 enabled auto-merge (squash) June 18, 2025 03:21
@freakboy3742
freakboy3742 merged commit 9f63a54 into python:3.14 Jun 18, 2025
@bedevere-app bedevere-app Bot removed the awaiting merge label Jun 18, 2025
@miss-islington
miss-islington deleted the backport-e4ccd46-3.14 branch January 2, 2026 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@freakboy3742 freakboy3742 freakboy3742 approved these changes
@barneygale barneygale Awaiting requested review from barneygale barneygale is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@miss-islington @freakboy3742 @hoodmane
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.