GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.14] gh-135532: simplify handling of HACL* errors in `_hmac` (GH-135740) by miss-islington · Pull Request #135743 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Jun 20, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

(cherry picked from commit 2dbada1)

Co-authored-by: Bénédikt Tran [email protected]

  • Issue: Rewrite & cleanup HACL*-based extension modules #135532

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@picnixz @miss-islington
pythongh-135532: simplify handling of HACL* errors in _hmac (python…
fdad74d 
…GH-135740)

(cherry picked from commit 2dbada1)

Co-authored-by: Bénédikt Tran <[email protected]>
@miss-islington
miss-islington requested review from gpshead and picnixz as code owners June 20, 2025 08:57
@bedevere-app bedevere-app Bot added awaiting review skip news labels Jun 20, 2025
This was referenced Jun 20, 2025
gh-135532: simplify handling of HACL* errors in _hmac #135740
Merged
Rewrite & cleanup HACL*-based extension modules #135532
Closed
@picnixz
picnixz enabled auto-merge (squash) June 20, 2025 08:58
@picnixz
picnixz merged commit d057cb4 into python:3.14 Jun 20, 2025
@bedevere-app bedevere-app Bot removed the awaiting review label Jun 20, 2025
@miss-islington
miss-islington deleted the backport-2dbada1-3.14 branch January 2, 2026 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpshead gpshead Awaiting requested review from gpshead gpshead is a code owner
@picnixz picnixz Awaiting requested review from picnixz picnixz is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@miss-islington @picnixz
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.