GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.14] gh-135755: rename undocumented `HACL_CAN_COMPILE_SIMD{128,256}` macros (GH-135847) by picnixz · Pull Request #136045 · python/cpython

Conversation

@picnixz

@picnixz picnixz commented Jun 27, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Rename undocumented HACL_CAN_COMPILE_SIMD{128,256} macros to _Py_HACL_CAN_COMPILE_VEC{128,256}. These macros are private. (cherry picked from commit 1e975ae)

  • Issue: Undocumented 3.14 C API #135755

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@picnixz
[3.14] pythongh-135755: rename undocumented `HACL_CAN_COMPILE_SIMD{12…
25dabcd 
…8,256}` macros (pythonGH-135847)

Rename undocumented `HACL_CAN_COMPILE_SIMD{128,256}` macros
to `_Py_HACL_CAN_COMPILE_VEC{128,256}`. These macros are private.
(cherry picked from commit 1e975ae)

Co-authored-by: Bénédikt Tran <[email protected]>
@bedevere-app bedevere-app Bot added the skip news label Jun 27, 2025
This was referenced Jun 27, 2025
gh-135755: rename undocumented HACL_CAN_COMPILE_SIMD{128,256} macros #135847
Merged
Undocumented 3.14 C API #135755
Closed
@picnixz

picnixz commented Jun 27, 2025

Copy link
Copy Markdown
Member Author

Ok, so blake2module actually changed because of my recent refactor. I'm almost tempted to backport the refactor from blake2 to 3.14 as well because any changes in blake2 will lead to conflicts. OTOH, it's a long rewrite and I think it's better if we make manual backports in the future. I doubt we'll need to touch more those modules (I mean, they are pretty... stable in general).
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@picnixz

picnixz commented Jun 27, 2025

Copy link
Copy Markdown
Member Author

!buildbot FIPS only
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-bot

bedevere-bot commented Jun 27, 2025

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @picnixz for commit 25dabcd 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F136045%2Fmerge

The command will test the builders whose names match following regular expression: FIPS only

The builders matched are:

  • AMD64 RHEL8 FIPS Only Blake2 Builtin Hash PR
  • AMD64 CentOS9 FIPS Only Blake2 Builtin Hash PR
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@picnixz
picnixz marked this pull request as ready for review June 28, 2025 08:01
@picnixz
picnixz requested review from a team, corona10, erlend-aasland, gpshead and tiran as code owners June 28, 2025 08:01
@bedevere-app bedevere-app Bot added the awaiting core review label Jun 28, 2025
@picnixz
picnixz merged commit 7028095 into python:3.14 Jun 28, 2025
@bedevere-app bedevere-app Bot removed the awaiting core review label Jun 28, 2025
@picnixz
picnixz deleted the backport-1e975ae-3.14 branch June 28, 2025 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpshead gpshead Awaiting requested review from gpshead gpshead is a code owner
@tiran tiran Awaiting requested review from tiran
@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner
@corona10 corona10 Awaiting requested review from corona10 corona10 is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@picnixz @bedevere-bot
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.