GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-130425: Add "Did you mean [...]" suggestions for `del obj.attr` by Pranjal095 · Pull Request #136588 · python/cpython

Conversation

@Pranjal095

@Pranjal095 Pranjal095 commented Jul 12, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

This pull request replaces the earlier PR #130799 (now closed) and carries over that set of commits, preserving original authorship and history. An extra commit has been included to address a linting issue that was present in the previous version.

Issue: #130425

  • Issue: Provide name suggestions for failed attribute deletions #130425

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
sobolevn and others added 11 commits July 12, 2025 20:36
@sobolevn @Pranjal095
pythongh-130425: Add "Did you mean" suggestion for del obj.attr
ee4081f
@sobolevn @Pranjal095
Update NEWS
cf9a052
@Pranjal095
pythongh-130428: Add tests for delattr suggestions
c369876
@Pranjal095
Refactored getattr and delattr tests
04254ad
@Pranjal095
Added else branches to handle unrecognized operations
57deaf3
@Pranjal095
Refactor getattr and setattr suggestion tests
bbae851
@nedbat @Pranjal095
docs: -I also implies -P (python#131539)
8ba26c4
@sobolevn @Pranjal095
pythonGH-134236: make regen-all (pythonGH-134237)
b1210dd
@tomasr8 @Pranjal095
pythonGH-131798: Optimize away isinstance calls in the JIT (pythonGH-…
60e6243 
…134369)
@Pranjal095
Refactor getattr and delattr suggestion tests
0ecb6d8
@Pranjal095
Fix linting issue
9a4e53b
@Pranjal095
Pranjal095 requested review from markshannon and methane as code owners July 12, 2025 15:41
@bedevere-app bedevere-app Bot added the awaiting review label Jul 12, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Jul 12, 2025
Provide name suggestions for failed attribute deletions #130425
Closed
picnixz
picnixz reviewed Jul 12, 2025
View reviewed changes
Comment thread Lib/test/test_traceback.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/test/test_traceback.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/test/test_traceback.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/test/test_traceback.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/test/test_traceback.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@picnixz picnixz changed the title gh-130425: Add "Did you mean [...]" suggestions for del obj.attr gh-130425: Add "Did you mean [...]" suggestions for del obj.attr Jul 12, 2025
@picnixz
picnixz requested a review from sobolevn July 12, 2025 15:57
Pranjal095 added 2 commits July 12, 2025 23:08
@Pranjal095
Add requested changes
d1e38c2
@Pranjal095
Merge remote-tracking branch 'upstream/main' into delattr-suggestions-re
9a361aa
@Pranjal095
Pranjal095 requested a review from picnixz July 12, 2025 18:02
picnixz
picnixz reviewed Jul 12, 2025
View reviewed changes
Comment thread Lib/test/test_traceback.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Misc/NEWS.d/next/Core_and_Builtins/2025-02-22-01-23-23.gh-issue-130425.x5SNQ8.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Objects/dictobject.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@Pranjal095
Add requested changes
fb654a4
@Pranjal095
Pranjal095 requested a review from picnixz July 12, 2025 18:35
picnixz
picnixz reviewed Jul 12, 2025
View reviewed changes
Comment thread Doc/whatsnew/3.15.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/whatsnew/3.15.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/whatsnew/3.15.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@Pranjal095
Add requested changes
023ad72
@Pranjal095
Pranjal095 requested a review from picnixz July 12, 2025 18:58
@Pranjal095
Fix doc indentation issue
0b9b2e4
StanFromIreland
StanFromIreland reviewed Jul 13, 2025
View reviewed changes
Comment thread Doc/whatsnew/3.15.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
@Pranjal095
Make requested change
ae0da23
@StanFromIreland

StanFromIreland commented Jul 13, 2025

Copy link
Copy Markdown
Member

@Pranjal095 Please mark comments as Resolved when you are finished with them, it helps keep the PR organized.
Pranjal095 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
picnixz
picnixz reviewed Jul 14, 2025
View reviewed changes
Comment thread Doc/whatsnew/3.15.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/test/test_traceback.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@Pranjal095
Make requested changes
6f7e03a
@Pranjal095
Pranjal095 requested a review from picnixz July 14, 2025 16:42
picnixz
picnixz reviewed Aug 2, 2025
View reviewed changes
Comment thread Doc/whatsnew/3.15.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/whatsnew/3.15.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Doc/whatsnew/3.15.rst Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/test/test_traceback.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@Pranjal095
Add requested changes
6488adb
@Pranjal095
Pranjal095 requested a review from picnixz August 2, 2025 10:56
picnixz
picnixz approved these changes Aug 2, 2025
View reviewed changes

@picnixz picnixz left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good now.

I'll let @sobolevn have a look as well as he's credited as a contributor as well.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Pranjal095 reacted with thumbs up emoji
All reactions
  • 👍 1 reaction
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Aug 2, 2025
@Pranjal095
Merge branch 'main' into delattr-suggestions-re
e008ea4
@Pranjal095
Pranjal095 requested a review from picnixz August 13, 2025 07:22
encukou added 2 commits August 19, 2025 10:25
@encukou
Parametrize getattr/setattr in get_suggestion
68ea8f1 
This allows moving test_suggestions_with_method_call back to
test_getattr_suggestions_underscored, so that delattr is tested
for these as well.
@encukou
Run test_suggestions_for_same_name for delattr too
30d8043
@encukou encukou mentioned this pull request Aug 19, 2025
Delattr suggestions re Pranjal095/cpython#1
Merged
@encukou

encukou commented Aug 19, 2025

Copy link
Copy Markdown
Member

I noticed that some of the setattr tests don't run for delattr, but could. See Pranjal095#1
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@Pranjal095
Merge pull request #1 from encukou/delattr-suggestions-re
8c9c597 
Delattr suggestions re
@Pranjal095
Pranjal095 requested a review from AA-Turner as a code owner August 19, 2025 09:18
@AA-Turner
AA-Turner removed their request for review August 19, 2025 09:22
@Pranjal095

Pranjal095 commented Aug 19, 2025

Copy link
Copy Markdown
Contributor Author

Thanks a lot for catching this! I hadn’t noticed the issue myself, and I’m very happy to have merged the changes.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
encukou
encukou approved these changes Aug 19, 2025
View reviewed changes

@encukou encukou left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sobolevn, I plan to merge around Friday if there are no objections.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@encukou
encukou merged commit f27af8b into python:main Aug 22, 2025
@bedevere-app bedevere-app Bot removed the awaiting merge label Aug 22, 2025
@Pranjal095
Pranjal095 deleted the delattr-suggestions-re branch August 22, 2025 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StanFromIreland StanFromIreland StanFromIreland left review comments
@encukou encukou encukou approved these changes
@methane methane Awaiting requested review from methane methane is a code owner
@markshannon markshannon Awaiting requested review from markshannon markshannon is a code owner
@sobolevn sobolevn Awaiting requested review from sobolevn
@picnixz picnixz Awaiting requested review from picnixz

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

7 participants

@Pranjal095 @StanFromIreland @encukou @picnixz @sobolevn @nedbat @tomasr8
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.