GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.13] gh-137400: Fix thread-safety issues when profiling all threads (gh-137518) by colesbury · Pull Request #137733 · python/cpython

Conversation

@colesbury

@colesbury colesbury commented Aug 13, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

There were a few thread-safety issues when profiling or tracing all threads via PyEval_SetProfileAllThreads or PyEval_SetTraceAllThreads:

  • The loop over thread states could crash if a thread exits concurrently (in both the free threading and default build)
  • The modification of c_profilefunc and c_tracefunc wasn't thread-safe on the free threading build. (cherry picked from commit a10152f)
  • Issue: sys._setprofileallthreads race condition #137400

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@colesbury
[3.13] pythongh-137400: Fix thread-safety issues when profiling all t…
4c8fa53 
…hreads (pythongh-137518)

There were a few thread-safety issues when profiling or tracing all
threads via PyEval_SetProfileAllThreads or PyEval_SetTraceAllThreads:

* The loop over thread states could crash if a thread exits concurrently
  (in both the free threading and default build)
* The modification of `c_profilefunc` and `c_tracefunc` wasn't
  thread-safe on the free threading build.
(cherry picked from commit a10152f)

Co-authored-by: Sam Gross <[email protected]>
This was referenced Aug 13, 2025
sys._setprofileallthreads race condition #137400
Closed
gh-137400: Fix thread-safety issues when profiling all threads #137518
Merged
@colesbury
Regen generated files
400617f
@Yhg1s

Yhg1s commented Aug 14, 2025

Copy link
Copy Markdown
Member

FYI, the ABI change seems fine to me.
colesbury reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
colesbury added 2 commits September 15, 2025 08:04
@colesbury
Merge remote-tracking branch 'origin/3.13' into backport-a10152f-3.13
d12ad7b
@colesbury
Regen abidump
3ce0e1c
@colesbury
colesbury marked this pull request as ready for review September 15, 2025 12:08
@colesbury
colesbury requested review from encukou, ericsnowcurrently and markshannon as code owners September 15, 2025 12:08
@bedevere-app bedevere-app Bot added the awaiting core review label Sep 15, 2025
@Yhg1s
Merge branch '3.13' into backport-a10152f-3.13
4cf3154
markshannon
markshannon reviewed Oct 3, 2025
View reviewed changes
Comment thread Lib/test/test_free_threading/test_monitoring.py
self.set = not self.set


@threading_helper.requires_working_threading()

@markshannon markshannon Oct 3, 2025

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Presumably this test should work regardless of the threading model?
So, maybe just run this test unconditionally?

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions

@colesbury colesbury Oct 7, 2025

Copy link
Copy Markdown
Contributor Author

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the InstrumentationMultiThreadedMixin subclasses hang on wasi where there are just no-op pthread stubs.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@colesbury
Merge branch '3.13' into backport-a10152f-3.13
42a0538
encukou
encukou approved these changes Oct 8, 2025
View reviewed changes

@encukou encukou left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The backport looks good to me!

Though, given that 3.13t is experimental and 3.14 is now out, maybe we should start thinking about not doing backports like this any more...

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Oct 8, 2025
@colesbury

colesbury commented Oct 9, 2025

Copy link
Copy Markdown
Contributor Author

Though, given that 3.13t is experimental and 3.14 is now out, maybe we should start thinking about not doing backports like this any more...

I generally agree, but one of the reasons I decided to backport this is that I think it will make the free-threaded CI more stable as well as fixing a thread-safety issue.
encukou reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@colesbury
colesbury merged commit 16d2e97 into python:3.13 Oct 9, 2025
5 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@colesbury
colesbury deleted the backport-a10152f-3.13 branch October 9, 2025 15:42
@bedevere-app bedevere-app Bot removed the awaiting merge label Oct 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markshannon markshannon markshannon left review comments
@encukou encukou encukou approved these changes
@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@colesbury @Yhg1s @encukou @markshannon
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.