GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-137044: Revert "gh-137044: Make resource.RLIM_INFINITY always positive (GH-137511)" by encukou · Pull Request #137938 · python/cpython

Conversation

@encukou

@encukou encukou commented Aug 19, 2025 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This reverts commit 0324c72.

@serhiy-storchaka: #137511 broke buildbots, and I'm worried about the misunderstanding in #137044 (comment)
I think it's best to revert now, so we don't need to rush a good fix. Do you agree?

  • Issue: resource library (getrlimit, setrlimit) interprets resource limits as signed integers instead of unsigned #137044

📚 Documentation preview 📚: https://cpython-previews--137938.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@encukou
Revert "pythongh-137044: Make resource.RLIM_INFINITY always positive (p…
6b8dc49 
…ythonGH-137511)"

This reverts commit 0324c72.
@encukou
encukou requested a review from serhiy-storchaka August 19, 2025 07:09
@encukou
encukou requested a review from AA-Turner as a code owner August 19, 2025 07:09
@bedevere-app bedevere-app Bot added the awaiting core review label Aug 19, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Aug 19, 2025
resource library (getrlimit, setrlimit) interprets resource limits as signed integers instead of unsigned #137044
Closed
@encukou encukou changed the title Revert "gh-137044: Make resource.RLIM_INFINITY always positive (GH-137511)" gh-137044: Revert "gh-137044: Make resource.RLIM_INFINITY always positive (GH-137511)" Aug 19, 2025
@serhiy-storchaka

serhiy-storchaka commented Aug 19, 2025

Copy link
Copy Markdown
Member

No, I think that we should just fix the tests. The behavior on 32-bit Linux is documented, I just don't have 32-bit Linux for testing now and missed the buildbot failure.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@encukou encukou closed this Aug 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka Awaiting requested review from serhiy-storchaka
@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting core review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@encukou @serhiy-storchaka
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.