GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-138122: Implement PEP 799 by pablogsal · Pull Request #138142 · python/cpython

Conversation

@pablogsal

@pablogsal pablogsal commented Aug 25, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member
  • Issue: Implement PEP 799 – A dedicated profiling package for organizing Python profiling tools #138122

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
johnslavik reacted with rocket emoji
All reactions
  • 🚀 1 reaction
@pablogsal
pablogsal requested review from AA-Turner and erlend-aasland as code owners August 25, 2025 15:22
@bedevere-app bedevere-app Bot added the awaiting core review label Aug 25, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Aug 25, 2025
Implement PEP 799 – A dedicated profiling package for organizing Python profiling tools #138122
Closed
@pablogsal
pythongh-138122: Implement PEP 799
3b3cd7e
@pablogsal
pablogsal force-pushed the gh-138122 branch from da8b0bc to 3b3cd7e Compare August 25, 2025 15:24
AA-Turner
AA-Turner reviewed Aug 25, 2025
View reviewed changes
Comment thread Lib/profiling/__init__.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/profiling/sampling/__init__.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/profiling/sampling/__init__.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/profiling/sampling/__main__.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/profiling/tracing/__init__.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/profiling/tracing/__init__.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/profiling/tracing/__init__.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/profiling/tracing/__main__.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/profiling/tracing/__init__.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
pablogsal and others added 3 commits August 26, 2025 15:57
@pablogsal @AA-Turner
Apply suggestions from code review
b2ec363 
Co-authored-by: Adam Turner <[email protected]>
@pablogsal
Move stuff to common module
3277076
@pablogsal
Fix lint
716dc9c
@pablogsal

pablogsal commented Aug 26, 2025

Copy link
Copy Markdown
Member Author

@encukou do you happen to know what I am missing for android?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@mhsmith

mhsmith commented Aug 26, 2025

Copy link
Copy Markdown
Member

I think profiling/tracing is missing from the directory list in Makefile.pre.in. Apparently Android is the only platform that runs the tests from a directory generated using make install.
encukou reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
AA-Turner
AA-Turner reviewed Aug 26, 2025
View reviewed changes
Comment thread Makefile.pre.in Resolved

Uh oh!

There was an error while loading. Please reload this page.
pablogsal and others added 2 commits August 26, 2025 23:14
@pablogsal @AA-Turner
Update Makefile.pre.in
1fa7d39 
Co-authored-by: Adam Turner <[email protected]>
@pablogsal
Small fix
228133d
pablogsal
pablogsal commented Aug 27, 2025
View reviewed changes
Comment thread Lib/profiling/sampling/__init__.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
pablogsal and others added 3 commits August 27, 2025 02:36
@pablogsal
Update __init__.py
4cf628a
@encukou
make regen-stdlib-module-names,
bf42bd3
@pablogsal
Merge remote-tracking branch 'upstream/main' into pythongh-138122
27ed2ad
encukou
encukou reviewed Aug 27, 2025
View reviewed changes
Comment thread Lib/profiling/sampling/sample.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@pablogsal
Update help command
4f1ad42
@pablogsal
pablogsal merged commit 56eb6b6 into python:main Aug 27, 2025
@pablogsal
pablogsal deleted the gh-138122 branch August 27, 2025 16:52
@bedevere-app bedevere-app Bot removed the awaiting core review label Aug 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@encukou encukou encukou left review comments
@AA-Turner AA-Turner AA-Turner left review comments
@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@pablogsal @mhsmith @encukou @AA-Turner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.