GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-138151: Fix `ForwardRef.evaluate()` for locally defined generics by dr-carlos · Pull Request #138161 · python/cpython

Conversation

@dr-carlos

@dr-carlos dr-carlos commented Aug 26, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Fixes #138151 with new associated tests.
Could be some edge cases (not covered in the test suite) which it doesn't consider.

  • Issue: annotationlib: ref.evaluate() not working for generics as local variables #138151

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
dr-carlos added 2 commits August 26, 2025 20:18
@dr-carlos
Fix generic ForwardRef evaluation with new locals
70decda
@dr-carlos
Add tests for ForwardRef.evaluate() on locally defined generics
9d1d98c
@dr-carlos
dr-carlos requested a review from JelleZijlstra as a code owner August 26, 2025 11:14
@bedevere-app bedevere-app Bot added the awaiting review label Aug 26, 2025
@bedevere-app

bedevere-app Bot commented Aug 26, 2025

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot mentioned this pull request Aug 26, 2025
annotationlib: ref.evaluate() not working for generics as local variables #138151
Closed
JelleZijlstra
JelleZijlstra reviewed Aug 26, 2025
View reviewed changes
Comment thread Lib/test/test_annotationlib.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
@dr-carlos
Update locally defined generics tests to explicitly make aliases `non…
f000205 
…local`
@bedevere-app

bedevere-app Bot commented Aug 27, 2025

Copy link
Copy Markdown

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@dr-carlos
Add NEWS entry
521cd9d
@JelleZijlstra

JelleZijlstra commented Sep 6, 2025

Copy link
Copy Markdown
Member

I'd like to merge #138164 instead of this one.
dr-carlos reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@dr-carlos

dr-carlos commented Sep 6, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor Author

I'd like to merge #138164 instead of this one.

Sounds good!
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@dr-carlos dr-carlos closed this Sep 6, 2025
@dr-carlos
dr-carlos deleted the forwardref-local-generic branch November 3, 2025 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@JelleZijlstra JelleZijlstra JelleZijlstra left review comments

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

annotationlib: ref.evaluate() not working for generics as local variables

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@dr-carlos @JelleZijlstra
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.