GeezerVison is showing github.com — gh-116738: Audit thread-safety for termios module by yoney · Pull Request #138395 · python/cpython
Conversation
yoney
commented
Sep 2, 2025
•
edited
Loading
Uh oh!
There was an error while loading. Please reload this page.
This is a placeholder PR to mark the termios module as audited in gh-116738 for thread safety in the free-threading build.
- The POSIX functions used by
termios are marked as MT-Safe in the Linux termios(3). There are no thread safety issues noted in the POSIX documentation.
- The current CPython implementation wraps posix functions with
Py_BEGIN_ALLOW_THREADS and Py_END_ALLOW_THREADS which assumes they are thread-safe.
- Additionally, the module tests were run under thread-sanitizer, which did not report any errors.
cc: @mpage @colesbury @Yhg1s
Note: This PR will be closed after termios is marked in gh-116738
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This is a placeholder PR to mark the termios module as audited
I don't understand the purpose of this PR. If no code change is needed, I suggest closing the PR.
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
This is a placeholder PR to mark the termios module as audited
I don't understand the purpose of this PR. If no code change is needed, I suggest closing the PR.
@vstinner Thank you for your feedback! Sorry for any confusion, my intention wasn’t to land this diff. I created this PR mainly as a placeholder to mark the termios module as audited in gh-116738. I added a note to the description, but I realise it might not be visible at the end. Could you please mark termios? I’ll go ahead and close this PR.
Thanks again!
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.