GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — [3.14] gh-71810: Fix _PyLong_AsByteArray() undefined behavior (GH-138873) by miss-islington · Pull Request #138883 · python/cpython

Conversation

@miss-islington

@miss-islington miss-islington commented Sep 14, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

Don't read p[-1] when p is an empty string: when n==0.
(cherry picked from commit 8b5ce31)

Co-authored-by: Victor Stinner [email protected]

  • Issue: int.to_bytes() and int.from_bytes(): raise ValueError when bytes count is zero #71810

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner @miss-islington
pythongh-71810: Fix _PyLong_AsByteArray() undefined behavior (pythonG…
e234ea6 
…H-138873)

Don't read p[-1] when p is an empty string: when n==0.
(cherry picked from commit 8b5ce31)

Co-authored-by: Victor Stinner <[email protected]>
@bedevere-app bedevere-app Bot added the awaiting review label Sep 14, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Sep 14, 2025
int.to_bytes() and int.from_bytes(): raise ValueError when bytes count is zero #71810
Closed
@bedevere-app bedevere-app Bot added the skip news label Sep 14, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Sep 14, 2025
gh-71810: Fix _PyLong_AsByteArray() undefined behavior #138873
Merged
vstinner
vstinner approved these changes Sep 14, 2025
View reviewed changes

@vstinner vstinner left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting review labels Sep 14, 2025
@vstinner
vstinner merged commit b343009 into python:3.14 Oct 7, 2025
@bedevere-app bedevere-app Bot removed the awaiting merge label Oct 7, 2025
@miss-islington
miss-islington deleted the backport-8b5ce31-3.14 branch January 2, 2026 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner vstinner approved these changes

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@miss-islington @vstinner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.