GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-129813, PEP 782: Use PyBytesWriter in _hashopenssl by vstinner · Pull Request #138922 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Sep 15, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Replace PyBytes_FromStringAndSize(NULL, size) with the new public PyBytesWriter API.

  • Issue: [C API] PEP 782: Add PyBytesWriter API #129813

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
pythongh-129813, PEP 782: Use PyBytesWriter in _hashopenssl
4735195 
Replace PyBytes_FromStringAndSize(NULL, size) with the new public
PyBytesWriter API.
@vstinner
vstinner requested review from gpshead and picnixz as code owners September 15, 2025 13:03
@vstinner vstinner added the skip news label Sep 15, 2025
@bedevere-app bedevere-app Bot added the awaiting core review label Sep 15, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Sep 15, 2025
[C API] PEP 782: Add PyBytesWriter API #129813
Closed
@vstinner

vstinner commented Sep 15, 2025

Copy link
Copy Markdown
Member Author

cc @picnixz
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
picnixz
picnixz reviewed Sep 15, 2025
View reviewed changes
Comment thread Modules/_hashopenssl.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Modules/_hashopenssl.c Resolved

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
Address Bénédikt's review
6a91098
@vstinner

vstinner commented Sep 15, 2025

Copy link
Copy Markdown
Member Author

@picnixz: Please review the updated code.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
picnixz
picnixz approved these changes Sep 15, 2025
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Sep 15, 2025
@picnixz

picnixz commented Sep 15, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Wait, does Create overallocate the buffer? because in sha3 and hashopenssl we don't need extra bytes (we just need the exact size that is asked).
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented Sep 15, 2025

Copy link
Copy Markdown
Member Author

Wait, does Create overallocate the buffer? because in sha3 and hashopenssl we don't need extra bytes (we just need the exact size that is asked).

PyBytesWrite_Create(n) allocates exactly n bytes, it doesn't use overallocation. Only PyBytesWriter_Grow() and PyBytesWriter_Resize() use overallocation.
picnixz reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
vstinner merged commit a68efdf into python:main Sep 15, 2025
@vstinner
vstinner deleted the pybyteswriter_hashopenssl branch September 15, 2025 16:41
@bedevere-app bedevere-app Bot removed the awaiting merge label Sep 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@picnixz picnixz picnixz approved these changes
@gpshead gpshead Awaiting requested review from gpshead gpshead is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@vstinner @picnixz
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.