GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-129813, PEP 782: Use PyBytesWriter in _sha3 by vstinner · Pull Request #138923 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Sep 15, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Replace PyBytes_FromStringAndSize(NULL, size) with the new public PyBytesWriter API.

  • Issue: [C API] PEP 782: Add PyBytesWriter API #129813

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
pythongh-129813, PEP 782: Use PyBytesWriter in _sha3
ef6c318 
Replace PyBytes_FromStringAndSize(NULL, size) with the new public
PyBytesWriter API.
@vstinner
vstinner requested a review from gpshead as a code owner September 15, 2025 13:26
@vstinner vstinner added the skip news label Sep 15, 2025
@vstinner
vstinner requested review from picnixz and tiran as code owners September 15, 2025 13:26
@bedevere-app bedevere-app Bot added the awaiting core review label Sep 15, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Sep 15, 2025
[C API] PEP 782: Add PyBytesWriter API #129813
Closed
@vstinner vstinner mentioned this pull request Sep 15, 2025
gh-135532: optimize calls to PyMem_Malloc in SHAKE digest computation #135744
Merged
@vstinner

vstinner commented Sep 15, 2025

Copy link
Copy Markdown
Member Author

cc @picnixz
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
picnixz
picnixz approved these changes Sep 15, 2025
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Sep 15, 2025
@picnixz

picnixz commented Sep 15, 2025

Copy link
Copy Markdown
Member

Note that I kept compact code toook similar to hexdigest(). So I would prefer keeping the same blank lines.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
Change blank lines in _sha3_shake_128_hexdigest_impl()
add8ef5
@vstinner

vstinner commented Sep 15, 2025

Copy link
Copy Markdown
Member Author

Note that I kept compact code toook similar to hexdigest(). So I would prefer keeping the same blank lines.

I changed _sha3_shake_128_hexdigest_impl() to use the same blank lines. Do you like it? Or do you prefer that I revert blank lines to the current code?
picnixz reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
picnixz
picnixz approved these changes Sep 15, 2025
View reviewed changes
@vstinner
vstinner merged commit f62b495 into python:main Sep 15, 2025
@vstinner
vstinner deleted the pybyteswriter_sha3 branch September 15, 2025 20:53
@bedevere-app bedevere-app Bot removed the awaiting merge label Sep 15, 2025
@vstinner

vstinner commented Sep 15, 2025

Copy link
Copy Markdown
Member Author

Merged, thanks for the review @picnixz.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@picnixz picnixz picnixz approved these changes
@gpshead gpshead Awaiting requested review from gpshead gpshead is a code owner
@tiran tiran Awaiting requested review from tiran

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@vstinner @picnixz
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.