GeezerVisonThe World Wide Web, restored to 800 pixels of glory. | |||||
| Home|About|Gaming cabinet|Archives|How it works|Starter sites | |||||
GeezerVison is showing github.com — gh-129813, PEP 782: Use PyBytesWriter in _ssl by vstinner · Pull Request #138929 · python/cpython Conversation
|
|
This is a performance critical function, please check that this has no slowdown on microbenchmark. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
Do you have advises on how to write such benchmark? Benchmarks on similar functions:
Creating a writer takes less than 30 ns, so time is dominated by I/O operations. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
I wrote a similar change to use |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
I am not worried about performance on this change. The more modern code (1) has the same complexity as the older code and (2) the CPU performance should already be dominated by the decryption that happens to generate the data being read in the first place - not our potential data copy if an internal resize were to move something. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
|
Merged, thanks for reviews. |
Sorry, something went wrong.
There was an error while loading. Please reload this page.
There was an error while loading. Please reload this page.
Successfully merging this pull request may close these issues.
There was an error while loading. Please reload this page.