GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-129813, PEP 782: Use PyBytesWriter in _ssl by vstinner · Pull Request #138929 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Sep 15, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Replace PyBytes_FromStringAndSize(NULL, size) and _PyBytes_Resize() with the new public PyBytesWriter API.

  • Issue: [C API] PEP 782: Add PyBytesWriter API #129813

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

All reactions
@vstinner
pythongh-129813, PEP 782: Use PyBytesWriter in _ssl
ff5d463
Replace PyBytes_FromStringAndSize(NULL, size) and _PyBytes_Resize()
with the new public PyBytesWriter API.
@vstinner
vstinner requested review from gpshead and picnixz as code owners September 15, 2025 14:51
@vstinner vstinner added the skip news label Sep 15, 2025
@bedevere-app bedevere-app Bot added the awaiting core review label Sep 15, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Sep 15, 2025
[C API] PEP 782: Add PyBytesWriter API #129813
Closed
@kumaraditya303

kumaraditya303 commented Sep 15, 2025

Copy link
Copy Markdown
Contributor

This is a performance critical function, please check that this has no slowdown on microbenchmark.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@vstinner

vstinner commented Sep 15, 2025

Copy link
Copy Markdown
Member Author

This is a performance critical function, please check that this has no slowdown on microbenchmark.

Do you have advises on how to write such benchmark?

Benchmarks on similar functions:

  • os.read(): gh-129813, PEP 782: Use PyBytesWriter in posix extension #138829 (comment)
  • io.FileIO.readall(): gh-129813, PEP 782: Use PyBytesWriter in _io.FileIO.readall #138901 (comment)

Creating a writer takes less than 30 ns, so time is dominated by I/O operations.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@vstinner

vstinner commented Sep 18, 2025

Copy link
Copy Markdown
Member Author

I wrote a similar change to use PyBytesWriter in socket.socket.recv(): #139097 (comment)

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

@gpshead

gpshead commented Sep 18, 2025

Copy link
Copy Markdown
Member

I am not worried about performance on this change. The more modern code (1) has the same complexity as the older code and (2) the CPU performance should already be dominated by the decryption that happens to generate the data being read in the first place - not our potential data copy if an internal resize were to move something.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

gpshead
gpshead approved these changes Sep 18, 2025
View reviewed changes
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Sep 18, 2025
@vstinner
vstinner merged commit 446587c into python:main Sep 18, 2025
@vstinner
vstinner deleted the pybyteswriter_ssl_read branch September 18, 2025 14:54
@bedevere-app bedevere-app Bot removed the awaiting merge label Sep 18, 2025
@vstinner

vstinner commented Sep 18, 2025

Copy link
Copy Markdown
Member Author

Merged, thanks for reviews.

All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gpshead gpshead gpshead approved these changes
@picnixz picnixz Awaiting requested review from picnixz picnixz is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@vstinner @kumaraditya303 @gpshead
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.