GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-137065: Revert "gh-105499: Merge typing.Union and types.UnionType (#105511)" by serhiy-storchaka · Pull Request #138967 · python/cpython

Conversation

@serhiy-storchaka

@serhiy-storchaka serhiy-storchaka commented Sep 16, 2025 •
edited by github-actions Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

This reverts commit d1db43c.
This reverts commit 0f511d8.
This reverts commit dc6d66f.

  • Issue: Merge 'types.UnionType' with typing._UnionGenericAlias, not typing.Union #137065

📚 Documentation preview 📚: https://cpython-previews--138967.org.readthedocs.build/

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
jorenham and rhettinger reacted with confused emoji
All reactions
  • 😕 2 reactions
@serhiy-storchaka
serhiy-storchaka requested a review from AA-Turner as a code owner September 16, 2025 09:03
@serhiy-storchaka serhiy-storchaka added the release-blocker label Sep 16, 2025
@serhiy-storchaka
serhiy-storchaka requested review from AlexWaygood, JelleZijlstra and rhettinger as code owners September 16, 2025 09:03
@serhiy-storchaka serhiy-storchaka added the needs backport to 3.14 bugs and security fixes label Sep 16, 2025
@serhiy-storchaka
serhiy-storchaka requested a review from ericvsmith as a code owner September 16, 2025 09:03
@github-project-automation github-project-automation Bot added this to Release and Deferred blockers 🚫 Sep 16, 2025
@github-project-automation github-project-automation Bot moved this to Todo in Release and Deferred blockers 🚫 Sep 16, 2025
@bedevere-app bedevere-app Bot added the awaiting core review label Sep 16, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Sep 16, 2025
Merge 'types.UnionType' with typing._UnionGenericAlias, not typing.Union #137065
Open
@serhiy-storchaka
pythongh-137065: Revert "pythongh-105499: Merge typing.Union and type…
5cd4a72 
…s.UnionType (python#105511)"

This reverts commit d1db43c.
This reverts commit 0f511d8.
This reverts commit dc6d66f.
@serhiy-storchaka
serhiy-storchaka force-pushed the revert-gh-105499 branch from efdd228 to 5cd4a72 Compare September 16, 2025 09:07
@serhiy-storchaka serhiy-storchaka mentioned this pull request Sep 16, 2025
gh-137065: Unmerge types.UnionType and typing.Union #137069
Closed
@serhiy-storchaka
Fix annotationlib.
e719e23
@rhettinger

rhettinger commented Sep 17, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

I agree that this should be reverted. It would be too difficult to change after a release.

It looks like concerns were raised from the outset and were not resolved before the PR was applied.
DanielNoord reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@hugovk

hugovk commented Sep 18, 2025

Copy link
Copy Markdown
Member

SC decided on the status quo.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@hugovk hugovk removed the release-blocker label Sep 18, 2025
@serhiy-storchaka

serhiy-storchaka commented Sep 18, 2025

Copy link
Copy Markdown
Member Author

Do you mean restoring the status quo?
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@serhiy-storchaka

serhiy-storchaka commented Sep 18, 2025

Copy link
Copy Markdown
Member Author

It is better to merge this PR earlier, because I may need a time to resolve conflicts with 3.14.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@hugovk

hugovk commented Sep 18, 2025

Copy link
Copy Markdown
Member

Sorry for the ambiguity. I meant keeping 3.14 as is, without this revert. The SC will post their decision later.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions

github-actions Bot commented Apr 29, 2026

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Apr 29, 2026
@serhiy-storchaka serhiy-storchaka added the needs backport to 3.15 bugs and security fixes label May 30, 2026
@github-actions github-actions Bot removed the stale Stale PR or inactive for long period of time. label Jun 1, 2026
@github-actions

github-actions Bot commented Sep 3, 2026

Copy link
Copy Markdown

This PR is stale because it has been open for 90 days with no activity.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Sep 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner
@JelleZijlstra JelleZijlstra Awaiting requested review from JelleZijlstra JelleZijlstra is a code owner
@AlexWaygood AlexWaygood Awaiting requested review from AlexWaygood AlexWaygood is a code owner
@rhettinger rhettinger Awaiting requested review from rhettinger rhettinger is a code owner
@ericvsmith ericvsmith Awaiting requested review from ericvsmith ericvsmith is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting core review needs backport to 3.14 bugs and security fixes needs backport to 3.15 bugs and security fixes stale Stale PR or inactive for long period of time.

Projects

Release and Deferred blockers 🚫
Status: Todo

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

3 participants

@serhiy-storchaka @rhettinger @hugovk
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.