GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-139109: Dynamic opcode targets by Fidget-Spinner · Pull Request #139111 · python/cpython

Conversation

@Fidget-Spinner

@Fidget-Spinner Fidget-Spinner commented Sep 18, 2025 •
edited
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

There is no taking up of an additional register on the computed goto build in _PyEval_EvalFrameDefault as the instruction dispatch table is already kept in a register on x86_64.

There is no regression in performance on both linux x86_64 and macOS AArch64 for tailcalling builds https://github.com/facebookexperimental/free-threading-benchmarking/tree/main/results/bm-20250917-3.15.0a0-178b03e-CLANG

  • Issue: Trace recording JIT #139109

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
Fidget-Spinner added 3 commits September 17, 2025 15:21
@Fidget-Spinner
Make opcode targets table dynamic
62f0b7a
@Fidget-Spinner
fix for tail call
178b03e
@Fidget-Spinner
Change name to not shout
406ccfa
@Fidget-Spinner
Fidget-Spinner requested a review from markshannon as a code owner September 18, 2025 10:43
@bedevere-app bedevere-app Bot added the awaiting core review label Sep 18, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Sep 18, 2025
Trace recording JIT #139109
Open
@Fidget-Spinner Fidget-Spinner added the skip news label Sep 18, 2025
Fidget-Spinner added 2 commits September 18, 2025 11:50
@Fidget-Spinner
fix
a2fd315
@Fidget-Spinner
Update _parser.py
00caa65
@Fidget-Spinner
Fidget-Spinner requested a review from ericsnowcurrently as a code owner September 18, 2025 12:18
Fidget-Spinner added 2 commits September 18, 2025 13:23
@Fidget-Spinner
Merge remote-tracking branch 'upstream/main' into dynamic_opcode_targets
867f283
@Fidget-Spinner
Merge remote-tracking branch 'upstream/main' into dynamic_opcode_targets
b2f3cdb
markshannon
markshannon approved these changes Sep 18, 2025
View reviewed changes

@markshannon markshannon left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Sep 18, 2025
@Fidget-Spinner
Fidget-Spinner merged commit a269e69 into python:main Sep 18, 2025
@bedevere-app bedevere-app Bot removed the awaiting merge label Sep 18, 2025
@Fidget-Spinner
Fidget-Spinner deleted the dynamic_opcode_targets branch September 18, 2025 13:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@markshannon markshannon markshannon approved these changes
@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@Fidget-Spinner @markshannon
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.