GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-64490: Tweak AC implementation for ``**kwds`` by AA-Turner · Pull Request #139133 · python/cpython

Conversation

@AA-Turner

@AA-Turner AA-Turner commented Sep 18, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Addresses @serhiy-storchaka's comments following initial merge (thank you Serhiy for the reviews!).

A

  • Issue: Argument Clinic should understand *args and **kwargs parameters #64490

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@AA-Turner
Address Serhiy's follow-up comments
6d016f1
@AA-Turner
AA-Turner requested a review from erlend-aasland as a code owner September 18, 2025 15:46
@AA-Turner AA-Turner added skip news topic-argument-clinic labels Sep 18, 2025
@bedevere-app bedevere-app Bot added the awaiting core review label Sep 18, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Sep 18, 2025
Argument Clinic should understand *args and **kwargs parameters #64490
Closed
@erlend-aasland
erlend-aasland requested review from serhiy-storchaka and removed request for erlend-aasland September 18, 2025 15:48
@erlend-aasland

erlend-aasland commented Sep 18, 2025

Copy link
Copy Markdown
Contributor

Deferring to Serhiy, as this is addressing his review remarks.
AA-Turner reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@AA-Turner
fixup! Address Serhiy's follow-up comments
88db6df
serhiy-storchaka
serhiy-storchaka reviewed Sep 18, 2025
View reviewed changes
Comment thread Lib/test/test_clinic.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
Comment thread Lib/test/test_clinic.py Resolved

Uh oh!

There was an error while loading. Please reload this page.
johncarlomartinez570-cmd
johncarlomartinez570-cmd approved these changes Oct 21, 2025
View reviewed changes
@github-actions

github-actions Bot commented Apr 29, 2026

Copy link
Copy Markdown

This PR is stale because it has been open for 30 days with no activity.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@github-actions github-actions Bot added the stale Stale PR or inactive for long period of time. label Apr 29, 2026
serhiy-storchaka added 3 commits August 22, 2026 11:43
@serhiy-storchaka
Merge remote-tracking branch 'upstream/main' into clinic/kwargs-simpl…
66697ca 
…e-followup
@serhiy-storchaka
Add tests for a bare ** and for var-positional in an optional group
c77c412
@serhiy-storchaka
Add tests for parameters after an optional group
7938b67
serhiy-storchaka
serhiy-storchaka approved these changes Aug 22, 2026
View reviewed changes

@serhiy-storchaka serhiy-storchaka left a comment

Copy link
Copy Markdown
Member

There was a problem hiding this comment.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved conflicts and added more tests to address my comments (including the one from 138344). LGTM now.

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@bedevere-app bedevere-app Bot added awaiting merge and removed awaiting core review labels Aug 22, 2026
@github-actions github-actions Bot removed the stale Stale PR or inactive for long period of time. label Aug 23, 2026
serhiy-storchaka added 3 commits September 27, 2026 22:07
@serhiy-storchaka
Merge remote-tracking branch 'upstream/main' into clinic/kwargs-simpl…
b9ba762 
…e-followup

# Conflicts:
#	Tools/clinic/libclinic/dsl_parser.py
@serhiy-storchaka
Merge remote-tracking branch 'upstream/main' into clinic/kwargs-simpl…
31d53ce 
…e-followup

# Conflicts:
#	Lib/test/test_clinic.py
@serhiy-storchaka
Reject a var-positional or var-keyword parameter in an optional group
a417c5b 
They were reported as an error on the following line, which was confusing: the closing ']' was blamed for following a var-keyword parameter.
@bedevere-app bedevere-app Bot added the type-feature A feature request or enhancement label Sep 28, 2026
@serhiy-storchaka
serhiy-storchaka merged commit c8b7c46 into python:main Sep 28, 2026
59 of 60 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@bedevere-app bedevere-app Bot removed the awaiting merge label Sep 28, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes
+1 more reviewer
@johncarlomartinez570-cmd johncarlomartinez570-cmd johncarlomartinez570-cmd approved these changes
Reviewers whose approvals may not affect merge requirements

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news topic-argument-clinic type-feature A feature request or enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

4 participants

@AA-Turner @erlend-aasland @serhiy-storchaka @johncarlomartinez570-cmd
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.