GeezerVison is showing github.com — gh-138013: Split TextIO tests from test_io.test_general by cmaloney · Pull Request #139173 · python/cpython
Conversation
cmaloney
commented
Sep 19, 2025
•
edited by bedevere-app
Bot
Loading
Uh oh!
There was an error while loading. Please reload this page.
These tests take 1.3 seconds on my dev machine, match fairly closely with testing textio.c implementation only.
I'm only planning one more split to these tests after this, finally moving the buffered out of test_general. Timings with -uall,largefile,extralargefile,walltime -M12G
- test_io.test_signals: 24.2 sec
- test_io.test_largefile: 10.0 sec
- test_io.test_general: 8.9 sec
- test_io.test_textio: 1.3 sec
- test_io.test_fileio: 375 ms
- test_io.test_bufferedio: 293 ms
- test_io.test_file: 87 ms
- test_io.test_memoryio: 56 ms
- test_io.test_univnewlines: 31 ms
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
These tests take 1.3 seconds on my dev machine, match fairly closely
with testing `textio.c` implementation only.
cmaloney
changed the title
gh-138013: Split TextIO tests from test_general
gh-138013: Split TextIO tests from testtest_general
Sep 19, 2025
cmaloney
changed the title
gh-138013: Split TextIO tests from testtest_general
gh-138013: Split TextIO tests from test_io.test_general
Sep 19, 2025
|
cc: @vstinner (only one more to go after this than test_io split will be done)
|
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
cmaloney reacted with thumbs up emoji
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Assignees
No one assigned
Milestone
No milestone
Development
Successfully merging this pull request may close these issues.
Uh oh!
There was an error while loading. Please reload this page.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.