GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-89973: Fix typo by hartwork · Pull Request #139405 · python/cpython

Conversation

@hartwork

@hartwork hartwork commented Sep 29, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Contributor

CC @picnixz

  • Issue: Document exceptions raised by fnmtach #89973

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@hartwork
Lib/test/test_fnmatch.py: Fix typo "less tha[t]"
abf9061
@bedevere-app bedevere-app Bot added awaiting review tests Tests in the Lib/test dir labels Sep 29, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Sep 29, 2025
Document exceptions raised by fnmtach #89973
Closed
@picnixz

picnixz commented Sep 29, 2025

Copy link
Copy Markdown
Member

Ah sorry, I should have explained for typos. In general, we don't fix typos that are not user-facing (that is, we only fix typos in docstrings, docs, error messages, etc, but usually, we don't fix typos in comments; that's to avoid having to backport them and to avoid code churn). If we were to rewrite the fnmatch() tests, then we would fix the typo because it's code that we would touch. Sorry, but this one won't be merged (we don't have an exact policy for typos... it's at the discretion of core devs, and the policy I take is shared by other core devs)
hartwork reacted with thumbs up emoji
All reactions
  • 👍 1 reaction

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@hartwork

hartwork commented Sep 29, 2025

Copy link
Copy Markdown
Contributor Author

@picnixz that's fair, I understand, no worries 👍
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@hartwork hartwork closed this Sep 29, 2025
@yihong0618 yihong0618 mentioned this pull request Oct 6, 2025
gh-139646: fix typo in pickletools error message #139647
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

awaiting review tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

2 participants

@hartwork @picnixz
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402503 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.