GV

GeezerVison

The World Wide Web, restored to 800 pixels of glory.

Home|About|Gaming cabinet|Archives|How it works|Starter sites

On this site

  • Sign in
  • ActionsCI/CD and automation
  • CodespacesCloud development environments
  • All Features
  • Documentation
  • Training
  • Certifications
  • Build with Copilot
  • Customize Copilot
  • Integrations
  • Trending repos
  • GitHub Sponsors
  • Developer articles
  • Enterprises

This view

  • Original page
  • New address

GeezerVison is showing github.com — gh-112075: Remove _PyObject_SetManagedDict() function by vstinner · Pull Request #139737 · python/cpython

Conversation

@vstinner

@vstinner vstinner commented Oct 7, 2025 •
edited by bedevere-app Bot
Loading

Uh oh!

There was an error while loading. Please reload this page.

Copy link
Copy Markdown
Member

Move it to the internal C API and no longer export it.

  • Issue: Make dict objects thread-safe in --disable-gil builds #112075

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
All reactions
@vstinner
pythongh-112075: Remove _PyObject_SetManagedDict() function
24cbdcf 
Move it to the internal C API and no longer export it.
@vstinner vstinner added the skip news label Oct 7, 2025
@bedevere-app bedevere-app Bot added the awaiting core review label Oct 7, 2025
@bedevere-app bedevere-app Bot mentioned this pull request Oct 7, 2025
Make dict objects thread-safe in --disable-gil builds #112075
Closed
@vstinner

vstinner commented Oct 7, 2025

Copy link
Copy Markdown
Member Author

The _PyObject_SetManagedDict() function is private, not documented, and not tested.

It's used by _PyObject_SetDict() which belongs to the internal C API and is not exported.

A code search in PyPI top 15,000 projects did not find any project using it.

The function was added by commit 8b541c0.

@DinoV: Did you add this function to the public C API on purpose?

cc @colesbury who modified the function.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner

vstinner commented Oct 12, 2025

Copy link
Copy Markdown
Member Author

Well, let me remove this function. It can be added back easily if things go wrong.

It's used by _PyObject_SetDict() which belongs to the internal C API and is not exported.

See also #139852 discussion about _PyObject_GetDictPtr() and maybe adding an idea to set the dictionary.
All reactions

Sorry, something went wrong.

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
vstinner merged commit 5f91d5d into python:main Oct 12, 2025
4 checks passed

Uh oh!

There was an error while loading. Please reload this page.
@vstinner
vstinner deleted the remove_set_managed_dict branch October 12, 2025 17:32
@bedevere-app bedevere-app Bot removed the awaiting core review label Oct 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Uh oh!

There was an error while loading. Please reload this page.

Assignees

No one assigned

Labels

skip news

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uh oh!

There was an error while loading. Please reload this page.

1 participant

@vstinner
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
You are visitor 01402520 — GeezerVison does not store the pages you look up.
Best viewed with Netscape Navigator 4.7 or Internet Explorer 6 at 800×600. No cookies required.